From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28173 invoked by alias); 29 Jan 2013 16:04:37 -0000 Received: (qmail 28163 invoked by uid 22791); 29 Jan 2013 16:04:36 -0000 X-SWARE-Spam-Status: No, hits=-4.1 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL X-Spam-Check-By: sourceware.org Received: from usevmg20.ericsson.net (HELO usevmg20.ericsson.net) (198.24.6.45) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 29 Jan 2013 16:04:31 +0000 Received: from EUSAAHC004.ericsson.se (Unknown_Domain [147.117.188.84]) by usevmg20.ericsson.net (Symantec Mail Security) with SMTP id DC.87.31450.E03F7015; Tue, 29 Jan 2013 17:04:30 +0100 (CET) Received: from EUSAAMB103.ericsson.se ([147.117.188.120]) by EUSAAHC004.ericsson.se ([147.117.188.84]) with mapi id 14.02.0318.004; Tue, 29 Jan 2013 11:04:30 -0500 From: Marc Khouzam To: 'Mircea Gherzan' CC: "'tromey@redhat.com'" , "'vladimir@codesourcery.com'" , "'gdb-patches@sourceware.org'" Subject: RE: [RFC] Fix the MI result of -break-insert with multiple locations Date: Tue, 29 Jan 2013 16:04:00 -0000 Message-ID: References: <1359470164-32004-1-git-send-email-mircea.gherzan@intel.com> <5107F02F.8070104@intel.com> In-Reply-To: <5107F02F.8070104@intel.com> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-01/txt/msg00685.txt.bz2 > -----Original Message----- > From: Mircea Gherzan [mailto:mircea.gherzan@intel.com]=20 > Sent: Tuesday, January 29, 2013 10:52 AM > To: Marc Khouzam > Cc: 'tromey@redhat.com'; 'vladimir@codesourcery.com';=20 > 'gdb-patches@sourceware.org' > Subject: Re: [RFC] Fix the MI result of -break-insert with=20 > multiple locations >=20 > On 29.01.2013 16:39, Marc Khouzam wrote: > > The above is an excerpt of the slightly more complete excerpt: > > body=3D[bkpt=3D{number=3D"1", ...},{number=3D"1.1",=20 > ...},{number=3D"1.2", ...}] > > > > and I think this fits with MI grammar: > > "body" =3D> variable > > =3D > > [bkpt=3D*] =3D> value which is a list > > and a list can be composed of many values which can be tuples: > > {number=3D"1", ...},{number=3D"1.1", ...},{number=3D"1.2", ...} >=20 > With a recent snapshot of the master branch [1], here's the=20 > full output=20 > without the patch: >=20 > (gdb) > -break-insert foobar > ^done,bkpt=3D{number=3D"1",type=3D"breakpoint",disp=3D"keep",enabled=3D" > y",addr=3D"",times=3D"0",original-location=3D"foobar"},{nu mber=3D"1.1",enabled=3D"y",addr=3D"0x00000000004008d7",func=3D"foobar()",fi= le=3D"overload.cpp",fullname=3D".../src/test-bktp-mi-> overload/overload.cp= p",line=3D"22",thread-groups=3D["i1"]},{number =3D"1.2",enabled=3D"y",addr=3D"0x00000000004008e0",func=3D"foobar(int)",fil= e=3D"overload.cpp",fullname=3D".../src/test-bktp-mi-> overload/overload.cpp= ",line=3D"26",thread-groups=3D["i1"]} > (gdb) >=20 > So no square brackets. Therefore not a list and IMHO not a=20 > valid MI output. You're right. The output I took was from -break-list, but for -break-insert, and probably some others, this does not look to be valid syntax. I like your proposal of=20 bkpt=3D{number=3D"1", ... , locations=3D[{number=3D"1.1", ...}, ...]} which would allow to easily differentiate between the "main bp entry" and the "sub entries". Marc >=20 > Thanks, > Mircea >=20 > [1] Commit f04df06ec3ee7785676ce4e5e2ee49cf73b286ab >=20 >=20 > --=20 >=20 > Intel GmbH > Dornacher Strasse 1 > 85622 Feldkirchen/Muenchen, Deutschland > Sitz der Gesellschaft: Feldkirchen bei Muenchen > Geschaeftsfuehrer: Christian Lamprechter, Hannes Schwaderer,=20 > Douglas Lusk > Registergericht: Muenchen HRB 47456 > Ust.-IdNr./VAT Registration No.: DE129385895 > Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052 >=20 >=20