From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15780 invoked by alias); 3 Jan 2013 15:38:22 -0000 Received: (qmail 15618 invoked by uid 22791); 3 Jan 2013 15:38:20 -0000 X-SWARE-Spam-Status: No, hits=-4.1 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL X-Spam-Check-By: sourceware.org Received: from imr4.ericy.com (HELO imr4.ericy.com) (198.24.6.9) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 03 Jan 2013 15:38:12 +0000 Received: from EUSAAHC003.ericsson.se ([147.117.188.81]) by imr4.ericy.com (8.14.3/8.14.3/Debian-9.1ubuntu1) with ESMTP id r03FpvNW012033; Thu, 3 Jan 2013 09:51:58 -0600 Received: from EUSAAMB103.ericsson.se ([147.117.188.120]) by EUSAAHC003.ericsson.se ([147.117.188.81]) with mapi id 14.02.0318.004; Thu, 3 Jan 2013 10:38:05 -0500 From: Marc Khouzam To: "'Jan Kratochvil'" CC: "'Tom Tromey'" , "'gdb-patches@sourceware.org'" Subject: RE: [commit] [rfc] Print MI fullname even for non-existing files Date: Thu, 03 Jan 2013 15:38:00 -0000 Message-ID: References: <20121217155859.GA8029@host2.jankratochvil.net> <8738z4y1el.fsf@fleche.redhat.com> <20121225080350.GB11349@host2.jankratochvil.net> In-Reply-To: <20121225080350.GB11349@host2.jankratochvil.net> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-01/txt/msg00038.txt.bz2 > -----Original Message----- > From: Jan Kratochvil [mailto:jan.kratochvil@redhat.com]=20 > Sent: Tuesday, December 25, 2012 3:04 AM > To: Marc Khouzam > Cc: 'Tom Tromey'; 'gdb-patches@sourceware.org' > Subject: [commit] [rfc] Print MI fullname even for non-existing files >=20 > On Thu, 20 Dec 2012 15:32:55 +0100, Marc Khouzam wrote: > > > Jan> symtab_to_fullname now always returns non-NULL. > > >=20 > > > Jan> Currently this patch only changes from user point of view MI: > > > Jan> (gdb) -file-list-exec-source-file > > > Jan> ^done,line=3D"1",file=3D"deleted.c",macro-info=3D"0" > > > ->=20 > > > Jan>=20=09 > > > ^done,line=3D"1",file=3D"deleted.c",fullname=3D"/path/to/deleted.c", > > > macro-info=3D"0" > > >=20 > > > Jan> Is there a serious reason why fullname was suppressed for > > > Jan> non-existing files? While it breaks MI compatibility in=20 > > > some way I > > > Jan> find it an acceptable change. > > >=20 > > > It seems pretty reasonable to me as well. > >=20 > > For what it's worth, that is an ok change for Eclipse (we don't > > use that command). >=20 > This specific command was just an example. The change=20 > affects any MI output > where fullname=3D"/abs/path" was printed. Now it will be=20 > printed even if that > source file is not present on the disk. While that may be=20 > rather rate case it > would be bad if Eclipse breaks. >=20 > I have tested now eclipse-cdt-8.1.1-1.fc18.x86_64, if I=20 Thanks for doing this! > remove /usr/src/debug > I get: >=20 > unpatched/patched present file: > Subwindow tab title shows the short filename "ioputs.c". >=20 > unpatched missing file: > Can't find a source file at "ioputs.c"=20 > Locate the file or edit the source lookup path to include its=20 > location. > Subwindow tab title shows the short filename "ioputs.c": > http://people.redhat.com/~jkratoch/eclipse-gdb-unpatched.png >=20 > patched missing file: > Can't find a source file at=20 > "/usr/src/debug/glibc-2.16-75f0d304/libio/ioputs.c" > Locate the file or edit the source lookup path to include its=20 > location. > Subwindow tab title shows the fullname=20 > "/usr/src/debug/glibc-2.16-75f0d304/libio/ioputs.c": > http://people.redhat.com/~jkratoch/eclipse-gdb-fullname.png >=20 > So I find the patch in fact an improvement even for Eclipse. Agreed. > Therefore I have checked it in: > http://sourceware.org/ml/gdb-cvs/2012-12/msg00184.html >=20 > Besides that the compatibility of Eclipse <-> GDB across=20 > versions is not too > great, FSF GDB HEAD fails with eclipse-cdt-8.0.1-4.fc16.x86_64: > Error in final launch sequence > Failed to execute MI command: > maintenance set python print-stack off > Error message from debugger back end: > Undefined maintenance set command: "python print-stack=20 > off". Try "help maintenance set". This has been fixed in cdt-8.0.2: https://bugs.eclipse.org/bugs/show_bug.cgi?id=3D367788 Thanks again Marc