From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1906 invoked by alias); 15 Nov 2012 16:44:51 -0000 Received: (qmail 1893 invoked by uid 22791); 15 Nov 2012 16:44:48 -0000 X-SWARE-Spam-Status: No, hits=-4.1 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL X-Spam-Check-By: sourceware.org Received: from imr3.ericy.com (HELO imr3.ericy.com) (198.24.6.13) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 15 Nov 2012 16:44:38 +0000 Received: from eusaamw0706.eamcs.ericsson.se ([147.117.20.31]) by imr3.ericy.com (8.13.8/8.13.8) with ESMTP id qAFGiUcj009246 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=FAIL); Thu, 15 Nov 2012 10:44:30 -0600 Received: from EUSAAHC003.ericsson.se (147.117.188.81) by eusaamw0706.eamcs.ericsson.se (147.117.20.31) with Microsoft SMTP Server (TLS) id 8.3.279.1; Thu, 15 Nov 2012 11:44:30 -0500 Received: from EUSAAMB103.ericsson.se ([147.117.188.120]) by EUSAAHC003.ericsson.se ([147.117.188.81]) with mapi id 14.02.0318.001; Thu, 15 Nov 2012 11:44:29 -0500 From: Marc Khouzam To: "'lgustavo@codesourcery.com'" , "'Tom Tromey'" CC: "'Joel Brobecker'" , "'gdb-patches@sourceware.org'" Subject: RE: [PATCH] Fix mi "-var-create" regression Date: Thu, 15 Nov 2012 16:44:00 -0000 Message-ID: References: <5075D4FD.9050900@mentor.com> <20121014171805.GB3050@adacore.com> <507BFF97.2000900@codesourcery.com> <87y5j4ziof.fsf@fleche.redhat.com> <508DB53E.30507@codesourcery.com> <87625rwvcp.fsf@fleche.redhat.com> <50A3EF5D.4060607@codesourcery.com> In-Reply-To: <50A3EF5D.4060607@codesourcery.com> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-11/txt/msg00413.txt.bz2 > -----Original Message----- > From: gdb-patches-owner@sourceware.org=20 > [mailto:gdb-patches-owner@sourceware.org] On Behalf Of Luis Machado > Sent: Wednesday, November 14, 2012 2:22 PM > To: Tom Tromey > Cc: Joel Brobecker; gdb-patches@sourceware.org > Subject: Re: [PATCH] Fix mi "-var-create" regression >=20 > On 10/30/2012 06:36 PM, Tom Tromey wrote: > >>>>>> "Luis" =3D=3D Luis Machado writes: > > > > Luis> 2012-10-15 Luis Machado > > Luis> * value.c (value_actual_type): Check for=20 > TYPE_CODE_STRUCT > > Luis> target types. > > > > Luis> testsuite/ > > Luis> * mi-var-create-rtti.c: New file. > > Luis> * mi-var-create-rtti.exp: New file. > > > > This looks good to me. One tiny nit: > > > > Luis> Index: gdb/gdb/testsuite/gdb.mi/mi-var-create-rtti.exp > > Luis> + return -1; > > > > No need for a ";" here. > > > > Ok with this change. > > > > thanks, > > Tom >=20 > Thanks. I've checked this in now. Nice! Is it possible to put this in the 7_5 branch? Thanks Marc