From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9971 invoked by alias); 31 Oct 2012 19:10:24 -0000 Received: (qmail 9957 invoked by uid 22791); 31 Oct 2012 19:10:21 -0000 X-SWARE-Spam-Status: No, hits=-4.1 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL X-Spam-Check-By: sourceware.org Received: from imr4.ericy.com (HELO imr4.ericy.com) (198.24.6.9) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 31 Oct 2012 19:10:15 +0000 Received: from eusaamw0707.eamcs.ericsson.se ([147.117.20.32]) by imr4.ericy.com (8.14.3/8.14.3/Debian-9.1ubuntu1) with ESMTP id q9VJE9dT027577; Wed, 31 Oct 2012 14:14:10 -0500 Received: from EUSAAHC005.ericsson.se (147.117.188.87) by eusaamw0707.eamcs.ericsson.se (147.117.20.32) with Microsoft SMTP Server (TLS) id 8.3.279.1; Wed, 31 Oct 2012 15:09:56 -0400 Received: from EUSAAMB103.ericsson.se ([147.117.188.120]) by EUSAAHC005.ericsson.se ([147.117.188.87]) with mapi id 14.02.0318.001; Wed, 31 Oct 2012 15:09:56 -0400 From: Marc Khouzam To: "'Pedro Alves'" , "'dje@google.com'" CC: "'Yao Qi'" , "'gdb-patches@sourceware.org'" Subject: RE: [PATCH 2/2] new tracepoint downloaded MI notification. Date: Wed, 31 Oct 2012 19:10:00 -0000 Message-ID: References: <1348793347-12556-1-git-send-email-yao@codesourcery.com> <1348793347-12556-3-git-send-email-yao@codesourcery.com> <20604.20455.105300.495734@ruffy2.mtv.corp.google.com> <509167D4.20007@redhat.com> In-Reply-To: <509167D4.20007@redhat.com> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-10/txt/msg00567.txt.bz2 > -----Original Message----- > From: gdb-patches-owner@sourceware.org=20 > [mailto:gdb-patches-owner@sourceware.org] On Behalf Of Pedro Alves > Sent: Wednesday, October 31, 2012 2:03 PM > To: dje@google.com > Cc: Yao Qi; gdb-patches@sourceware.org > Subject: Re: [PATCH 2/2] new tracepoint downloaded MI notification. >=20 > > > 2012-09-27 Yao Qi > > >=20 > > > * gdb.trace/mi-traceframe-changed.exp=20 > (test_tfind_remote): Adjust. > > > * gdb.trace/mi-tracepoint-downloaded.exp: New. > >=20 > > Hi. > > It would be useful if the reason why this notification=20 > exists was specified in the code. > > E.g, "This notification exists because frontends ... [fill=20 > in the blank]." >=20 > Yes, indeed. I'll probably upgrade that "useful" to "required". :-) > It is not clear for example, why would the frontend > care about a particular tracepoint having been downloaded. I can see > it wanting to know when a trace run has started from the CLI,=20 > for instance, > which already implies that tracepoints have been downloaded. In older GDB versions, when creating a tracepoint during a trace run, that tracepoint would not be pushed to the target until the next trace run. The idea is that a frontend could indicate which tracespoints were active on the target and which were not. Now that GDB pushes new tracepoints to the target immediately, that use-case may not apply, but I wonder if there are other situations where some tracepoints will be on the target and other will not? Marc