Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Jason Molenda <jmolenda@apple.com>
To: gdb-patches@sources.redhat.com
Subject: Re: [patch] remove extraneous check_typedef () call in c_val_print ()
Date: Fri, 31 Aug 2001 14:41:00 -0000	[thread overview]
Message-ID: <E557604E-9E58-11D5-BF6F-000393540DDC@apple.com> (raw)
In-Reply-To: <AC0855EE-9E58-11D5-BF6F-000393540DDC@apple.com>

[-- Attachment #1: Type: text/plain, Size: 543 bytes --]

On Friday, August 31, 2001, at 02:39 PM, Jason Molenda wrote:

> Hello, my name is Jason Molenda, here is my first patch submission to 
> GDB.  I've heard that my employer has a copyright assignment on file 
> already, so I expect those details are all in order.  If I've missed 
> some bit of documentation about how to submit a patch properly, please 
> let me know.
>

Including the patch would be a good first step, I suppose.  BTW I did 
run the gdb testsuite with this patch and there are no additional 
regressions.  Here's the patch:


[-- Attachment #2: pa --]
[-- Type: text/x-diff, Size: 665 bytes --]

2001-08-31  Jason Molenda  (jmolenda@apple.com)

	* c-valprint.c (c_val_print):  Second call to check_typedef ()
	is no longer necessary.

Index: c-valprint.c
===================================================================
RCS file: /cvs/src/src/gdb/c-valprint.c,v
retrieving revision 1.9
diff -u -p -r1.9 c-valprint.c
--- c-valprint.c	2001/04/27 00:19:09	1.9
+++ c-valprint.c	2001/08/31 21:29:04
@@ -168,7 +168,6 @@ c_val_print (struct type *type, char *va
 	{
 	  addr = unpack_pointer (type, valaddr + embedded_offset);
 	print_unpacked_pointer:
-	  elttype = check_typedef (TYPE_TARGET_TYPE (type));
 
 	  if (TYPE_CODE (elttype) == TYPE_CODE_FUNC)
 	    {

  reply	other threads:[~2001-08-31 14:41 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-08-31 14:40 Jason Molenda
2001-08-31 14:41 ` Jason Molenda [this message]
2001-09-05 16:27   ` Michael Snyder
2001-09-05 17:34   ` Andrew Cagney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E557604E-9E58-11D5-BF6F-000393540DDC@apple.com \
    --to=jmolenda@apple.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox