Re: [RFA Darwin]: Add push_dummy_call for i386

Tristan Gingold
2009-07-06T07:00:35Z

On Jul 3, 2009, at 6:55 PM, Joseph S. Myers wrote:

> On Fri, 3 Jul 2009, Tristan Gingold wrote:
>
>> Hi,
>>
>> Darwin i386 ABI is slightly different from the SVR4 one. In
>> particular
>> stack alignment is 16. As a consquence, i386 Darwin can't use the
>> standard
>> i386-tdeo.c push_dummy_call and this patch provides a Darwin
>> version of this
>> call.
>
> Are there tests in the testsuite (of GDB knowing how SSE vector
> arguments
> and function returns are handled) that this fixes? (There are such
> tests
> for AltiVec and e500 vectors, for example.)

This example fixes many tests in callfuncs.exp. If gdb calls malloc()
(eg to allocate a string) with
a wrong stack alignment, the inferior will crash (as it looks like
malloc or one of its callees uses sse).

That's said, I haven't seen tests for SSE vector arguments/return.

Tristan.