From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1515 invoked by alias); 7 Jan 2019 16:57:34 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 1500 invoked by uid 89); 7 Jan 2019 16:57:34 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: EUR02-AM5-obe.outbound.protection.outlook.com Received: from mail-eopbgr00052.outbound.protection.outlook.com (HELO EUR02-AM5-obe.outbound.protection.outlook.com) (40.107.0.52) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 07 Jan 2019 16:57:29 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OJepWDgqgtoWwBsHphS78CzuO/nByj93yzbJZ19jyng=; b=m24B8jUAjFVKXabS/JRge7GZtKnQWIafmp78wM32uLwnF2MTzR5u8hxhBpfHbFT+qBAgINnPdgqefXXCVP+S0DYYVvHrgV+FxjfI5MOAbvk988vI6Rt72A98Vlfat0pRj1EaM/bLdXPzm/xM96A+7W2a/1VGRASVpzLwfynUEZs= Received: from DB6PR0802MB2133.eurprd08.prod.outlook.com (10.172.226.148) by DB6PR0802MB2343.eurprd08.prod.outlook.com (10.172.228.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1495.6; Mon, 7 Jan 2019 16:57:26 +0000 Received: from DB6PR0802MB2133.eurprd08.prod.outlook.com ([fe80::140c:5689:da7f:569a]) by DB6PR0802MB2133.eurprd08.prod.outlook.com ([fe80::140c:5689:da7f:569a%7]) with mapi id 15.20.1495.011; Mon, 7 Jan 2019 16:57:26 +0000 From: Alan Hayward To: "gdb-patches@sourceware.org" CC: nd Subject: Re: [PATCH] Testsuite: Ensure stack protection is off for GCC Date: Mon, 07 Jan 2019 16:57:00 -0000 Message-ID: References: <20190107163715.5591-1-alan.hayward@arm.com> In-Reply-To: <20190107163715.5591-1-alan.hayward@arm.com> authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alan.Hayward@arm.com; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) Content-Type: text/plain; charset="us-ascii" Content-ID: <4CCB485811BC5744A52B379C6617D1E9@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-IsSubscribed: yes X-SW-Source: 2019-01/txt/msg00135.txt.bz2 Forgot to mention: this fixes ~60 tests when running make check on Ubuntu. > On 7 Jan 2019, at 16:37, Alan Hayward wrote: >=20 > Using -fstack-protector-strong will cause GDB to break on the wrong line > when placing a breakpoint on a function. This is caused by due to > inadequate dwarf line numbering, and is being tracked by the GCC bug > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D88432 >=20 > GCC (and Clang) provided by Debian/Ubuntu default to Stack Protector > being enabled. >=20 > So, ensure that when running the GDB testsuite, stack protector is always > turned off for GCC (option has existed since GCC 4.1.0). >=20 > Also, ensure that this does not cause infinite recursion due to > test_compiler_info having to compile a file itself. >=20 > Restore change in ovldbreak.exp which worked around the issue. >=20 > [Side note - this fix would be improved by checking for Ubuntu/Debian, > but I don't see any existing checks for that in the testsuite] >=20 > 2019-01-07 Alan Hayward >=20 > * gdb.cp/ovldbreak.exp: Only allow a single break line. > * lib/gdb.exp (get_compiler_info): Use getting_compiler_info option. > (gdb_compile): Remove stack protector for GCC and prevent recursion. > --- > gdb/testsuite/gdb.cp/ovldbreak.exp | 2 +- > gdb/testsuite/lib/gdb.exp | 17 +++++++++++++++-- > 2 files changed, 16 insertions(+), 3 deletions(-) >=20 > diff --git a/gdb/testsuite/gdb.cp/ovldbreak.exp b/gdb/testsuite/gdb.cp/ov= ldbreak.exp > index 494f2a12e9..3ffd04209a 100644 > --- a/gdb/testsuite/gdb.cp/ovldbreak.exp > +++ b/gdb/testsuite/gdb.cp/ovldbreak.exp > @@ -209,7 +209,7 @@ for {set idx 0} {$idx < [llength $overloads]} {incr i= dx} { >=20 > # Verify the breakpoints. > set bptable "Num\[\t \]+Type\[\t \]+Disp Enb Address\[\t \]+What.*\[\r\n]= +" > -append bptable "\[0-9\]+\[\t \]+breakpoint\[\t \]+keep\[\t \]y\[\t \]+$h= ex\[\t \]+in main(\\((|void)\\))? at.*$srcfile:4\[89\]\[\r\n\]+" > +append bptable "\[0-9\]+\[\t \]+breakpoint\[\t \]+keep\[\t \]y\[\t \]+$h= ex\[\t \]+in main(\\((|void)\\))? at.*$srcfile:49\[\r\n\]+" > append bptable "\[\t \]+breakpoint already hit 1 time\[\r\n\]+." > foreach ovld $overloads { > append bptable [format "\[0-9\]+\[\t \]+breakpoint\[\t \]+keep y\[\t = \]+$hex\[\t \]+in foo::overload1arg\\(%s\\) at.*$srcfile:%d\[\r\n\]+" $ovld= \ > diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp > index ed9f89d5a7..7443638a72 100644 > --- a/gdb/testsuite/lib/gdb.exp > +++ b/gdb/testsuite/lib/gdb.exp > @@ -3276,12 +3276,12 @@ proc get_compiler_info {{arg ""}} { > # We have to use -E and -o together, despite the comments > # above, because of how DejaGnu handles remote host testing. > set ppout "$outdir/compiler.i" > - gdb_compile "${ifile}" "$ppout" preprocess [list "$arg" quiet] > + gdb_compile "${ifile}" "$ppout" preprocess [list "$arg" quiet getting_c= ompiler_info] > set file [open $ppout r] > set cppout [read $file] > close $file > } else { > - set cppout [ gdb_compile "${ifile}" "" preprocess [list "$arg" quiet] ] > + set cppout [ gdb_compile "${ifile}" "" preprocess [list "$arg" quiet ge= tting_compiler_info] ] > } > eval log_file $saved_log >=20 > @@ -3519,6 +3519,7 @@ proc gdb_compile {source dest type options} { > } > set shlib_found 0 > set shlib_load 0 > + set getting_compiler_info 0 > foreach opt $options { > if {[regexp {^shlib=3D(.*)} $opt dummy_var shlib_name] > && $type =3D=3D "executable"} { > @@ -3549,11 +3550,23 @@ proc gdb_compile {source dest type options} { > } > } elseif { $opt =3D=3D "shlib_load" && $type =3D=3D "executable" } { > set shlib_load 1 > + } elseif { $opt =3D=3D "getting_compiler_info" } { > + # If this is set, calling test_compiler_info will cause recursion. > + set getting_compiler_info 1 > } else { > lappend new_options $opt > } > } >=20 > + # Ensure stack protector is disabled for GCC, as this will causes pr= oblems > + # with DWARF line numbering. > + # See https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D88432 > + # This option defaults to on for Debian/Ubuntu. > + if { $getting_compiler_info =3D=3D 0 && [test_compiler_info "gcc-*"]= } { > + # Put it at the front to not override any user-provided value > + lappend new_options "early_flags=3D-fno-stack-protector" > + } > + > # Because we link with libraries using their basename, we may need > # (depending on the platform) to set a special rpath value, to allow > # the executable to find the libraries it depends on. > --=20 > 2.17.2 (Apple Git-113) >=20