From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32077 invoked by alias); 26 Aug 2013 12:30:42 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 32064 invoked by uid 89); 26 Aug 2013 12:30:42 -0000 Received: from mga09.intel.com (HELO mga09.intel.com) (134.134.136.24) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 26 Aug 2013 12:30:42 +0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.6 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RDNS_NONE autolearn=no version=3.3.2 X-HELO: mga09.intel.com Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga102.jf.intel.com with ESMTP; 26 Aug 2013 05:27:47 -0700 X-ExtLoop1: 1 Received: from irsmsx101.ger.corp.intel.com ([163.33.3.153]) by orsmga002.jf.intel.com with ESMTP; 26 Aug 2013 05:30:38 -0700 Received: from irsmsx153.ger.corp.intel.com (163.33.192.75) by IRSMSX101.ger.corp.intel.com (163.33.3.153) with Microsoft SMTP Server (TLS) id 14.3.123.3; Mon, 26 Aug 2013 13:30:37 +0100 Received: from irsmsx106.ger.corp.intel.com ([169.254.8.233]) by IRSMSX153.ger.corp.intel.com ([169.254.9.218]) with mapi id 14.03.0123.003; Mon, 26 Aug 2013 13:30:37 +0100 From: "Bunk, Bernd" To: Pedro Alves CC: "tromey@redhat.com" , "eliz@gnu.org" , "gdb-patches@sourceware.org" Subject: RE: [PATCH v3] Added file properties to windows gdb executable for all mingw32 builds. Date: Mon, 26 Aug 2013 12:30:00 -0000 Message-ID: References: <1377273278-10370-1-git-send-email-bernd.bunk@intel.com> <52178748.9070909@redhat.com> In-Reply-To: <52178748.9070909@redhat.com> Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-SW-Source: 2013-08/txt/msg00736.txt.bz2 > -----Original Message----- > From: Pedro Alves [mailto:palves@redhat.com] > Sent: Friday, August 23, 2013 6:01 PM > To: Bunk, Bernd > Cc: tromey@redhat.com; palves@redhat.com; eliz@gnu.org; gdb- > patches@sourceware.org > Subject: Re: [PATCH v3] Added file properties to windows gdb executable > for all mingw32 builds. >=20 > On 08/23/2013 04:54 PM, Bernd Bunk wrote: > > On Windows OS it is custom that executables and DLL's show file > properties. > > These contain product name/version, file name/version, > company/copyright info. > > File properties are visible by right-click on the file, selecting > properties \ details. > > This patch adds file properties to the gdb executable for all mingw > builds. > > > > 2013-08-14 Bernd Bunk > > > > * Makefile.in (windows_exe_properties.h): Add rule to create > > windows_exe_properties.h header file with file property > information. > > (windows_exe_properties.o): Added rule to build the resource > file. >=20 > I didn't find where this was updated to write to a temporary file, and > then move to the final destination. Did I miss something? Sorry forgot to answer to this. As mentioned in a PATCH v2 answer, I don't= need to copy it. I just removed the $(srcdir) folder infront of the filen= ame in the shell script and added a "-I." to the build rule. So the RC fil= e now includes the header file from the local folder, which is the build fo= lder. But if you don't like this solution I can change it... >=20 > > * configure: Add windows_exe_properties.o to mingw32 specific > > objects. >=20 > configure is a generated file. You'll need to edit configure.ac > instead. >=20 > -- > Pedro Alves Intel GmbH Dornacher Strasse 1 85622 Feldkirchen/Muenchen, Deutschland Sitz der Gesellschaft: Feldkirchen bei Muenchen Geschaeftsfuehrer: Christian Lamprechter, Hannes Schwaderer, Douglas Lusk Registergericht: Muenchen HRB 47456 Ust.-IdNr./VAT Registration No.: DE129385895 Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052