From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27417 invoked by alias); 26 Aug 2013 12:25:02 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 27394 invoked by uid 89); 26 Aug 2013 12:25:02 -0000 Received: from mga01.intel.com (HELO mga01.intel.com) (192.55.52.88) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 26 Aug 2013 12:25:02 +0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.9 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RDNS_NONE autolearn=no version=3.3.2 X-HELO: mga01.intel.com Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga101.fm.intel.com with ESMTP; 26 Aug 2013 05:24:59 -0700 X-ExtLoop1: 1 Received: from irsmsx101.ger.corp.intel.com ([163.33.3.153]) by fmsmga002.fm.intel.com with ESMTP; 26 Aug 2013 05:24:57 -0700 Received: from irsmsx106.ger.corp.intel.com ([169.254.8.233]) by IRSMSX101.ger.corp.intel.com ([169.254.1.83]) with mapi id 14.03.0123.003; Mon, 26 Aug 2013 13:24:50 +0100 From: "Bunk, Bernd" To: Eli Zaretskii CC: "tromey@redhat.com" , "palves@redhat.com" , "gdb-patches@sourceware.org" Subject: RE: [PATCH v2] Added file properties to windows gdb executable for all mingw32 builds. Date: Mon, 26 Aug 2013 12:25:00 -0000 Message-ID: References: <1377161766-8318-1-git-send-email-bernd.bunk@intel.com> <8361uxkbi9.fsf@gnu.org> <83eh9kiic8.fsf@gnu.org> In-Reply-To: <83eh9kiic8.fsf@gnu.org> Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-SW-Source: 2013-08/txt/msg00734.txt.bz2 > -----Original Message----- > From: Eli Zaretskii [mailto:eliz@gnu.org] > Sent: Friday, August 23, 2013 4:37 PM > To: Bunk, Bernd > Cc: tromey@redhat.com; palves@redhat.com; gdb-patches@sourceware.org > Subject: Re: [PATCH v2] Added file properties to windows gdb executable > for all mingw32 builds. >=20 > > From: "Bunk, Bernd" > > CC: "tromey@redhat.com" , "palves@redhat.com" > > , "gdb-patches@sourceware.org" > > > > Date: Fri, 23 Aug 2013 13:44:58 +0000 > > > > > > +# check for environment variables to replace certain file > > > > +properties [ -n "$WIN_EXE_VERSION" ] && version=3D$WIN_EXE_VERSION > > > > +[ -n "$WIN_EXE_COMPANY_NAME" ] && > > > > +company_name=3D$WIN_EXE_COMPANY_NAME > > > > +[ -n "$WIN_EXE_FILE_DESCRIPTION" ] && > > > > +file_description=3D$WIN_EXE_FILE_DESCRIPTION > > > > +[ -n "$WIN_EXE_PRODUCT_NAME" ] && > > > > +product_name=3D$WIN_EXE_PRODUCT_NAME > > > > +[ -n "$WIN_EXE_INTERNAL_NAME" ] && > > > > +internal_name=3D$WIN_EXE_INTERNAL_NAME > > > > +[ -n "$WIN_EXE_ORIGINAL_FILENAME" ] && > > > > +original_filename=3D$WIN_EXE_ORIGINAL_FILENAME > > > > +[ -n "$WIN_EXE_COPYRIGHT" ] && copyright=3D$WIN_EXE_COPYRIGHT [ -n > > > > +"$WIN_EXE_LICENSE" ] && license=3D$WIN_EXE_LICENSE [ -n > > > > +"$WIN_EXE_CONFIGURED" ] && configured=3D$WIN_EXE_CONFIGURED [ -n > > > > +"$WIN_EXE_SUPPORT" ] && support=3D$WIN_EXE_SUPPORT > > > > > > This looks like unnecessary featurism to me. Is it really needed, > > > and if so, in what use cases? > > Yes, it is needed. Not in here, but for every company which > changes/adds and re-distributes gdb. > > I started this feature because our Product Validation does not like > binaries without legal information. > > And off course this is different depending on who ships the product. > > Without a way to change the strings the complete changeset would be > useless for me. >=20 > You can always modify the source of these attributes, can't you? It's > not like you change these strings several times a day, right? If I have to change/overwrite the sources for this feature just to use the = feature, where would be the reason for me to upstream it? I need parameter= s/env vars to customize the behavior during build, not changed sources that= I need to merge for every branch I have. The whole purpose of upstreaming= a feature is to NOT have custom sources for this feature. >=20 > > > > +#include "afxres.h" > > > > > > Is this header really needed? > > Yes, unfortunately. > > This header file "implements" the resource language used below in the > RC file. >=20 > Sorry, I don't understand: this header file in MinGW distribution just > includes windows.h, defines IDC_STATIC, and that's it. What do you > have in it? As clarified in another feedback - my mistake. I changed it to 'include "v= ersion.h"' in v3. I also tested it with using Visual Studio on this RC fil= e - still functional. Intel GmbH Dornacher Strasse 1 85622 Feldkirchen/Muenchen, Deutschland Sitz der Gesellschaft: Feldkirchen bei Muenchen Geschaeftsfuehrer: Christian Lamprechter, Hannes Schwaderer, Douglas Lusk Registergericht: Muenchen HRB 47456 Ust.-IdNr./VAT Registration No.: DE129385895 Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052