From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27180 invoked by alias); 23 Aug 2013 13:45:05 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 27162 invoked by uid 89); 23 Aug 2013 13:45:04 -0000 X-Spam-SWARE-Status: No, score=-7.5 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 Received: from mga02.intel.com (HELO mga02.intel.com) (134.134.136.20) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Fri, 23 Aug 2013 13:45:03 +0000 Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga101.jf.intel.com with ESMTP; 23 Aug 2013 06:45:01 -0700 X-ExtLoop1: 1 Received: from irsmsx101.ger.corp.intel.com ([163.33.3.153]) by orsmga002.jf.intel.com with ESMTP; 23 Aug 2013 06:44:59 -0700 Received: from irsmsx153.ger.corp.intel.com (163.33.192.75) by IRSMSX101.ger.corp.intel.com (163.33.3.153) with Microsoft SMTP Server (TLS) id 14.3.123.3; Fri, 23 Aug 2013 14:44:58 +0100 Received: from irsmsx106.ger.corp.intel.com ([169.254.8.233]) by IRSMSX153.ger.corp.intel.com ([169.254.9.218]) with mapi id 14.03.0123.003; Fri, 23 Aug 2013 14:44:58 +0100 From: "Bunk, Bernd" To: Eli Zaretskii CC: "tromey@redhat.com" , "palves@redhat.com" , "gdb-patches@sourceware.org" Subject: RE: [PATCH v2] Added file properties to windows gdb executable for all mingw32 builds. Date: Fri, 23 Aug 2013 13:45:00 -0000 Message-ID: References: <1377161766-8318-1-git-send-email-bernd.bunk@intel.com> <8361uxkbi9.fsf@gnu.org> In-Reply-To: <8361uxkbi9.fsf@gnu.org> Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-SW-Source: 2013-08/txt/msg00675.txt.bz2 > -----Original Message----- > From: Eli Zaretskii [mailto:eliz@gnu.org] > Sent: Thursday, August 22, 2013 5:10 PM > To: Bunk, Bernd > Cc: tromey@redhat.com; palves@redhat.com; gdb-patches@sourceware.org; > Bunk, Bernd > Subject: Re: [PATCH v2] Added file properties to windows gdb executable > for all mingw32 builds. >=20 > > From: Bernd Bunk > > Cc: gdb-patches@sourceware.org, Bernd Bunk > > Date: Thu, 22 Aug 2013 10:56:06 +0200 > > > > On Windows OS it is customary that executables and DLL's show file > properties. > > These contain product name/version, file name/version, > company/copyright info. > > File properties are visible by right-click on the file, selecting > properties \ details. > > This patch adds file properties to the gdb executable for all mingw > builds. >=20 > Thanks, this looks OK to me, except for a couple of comments: >=20 > > * Makefile.in (win_exe_properties.h): Add rule to create > > win_exe_properties.h header file with file property information. > > (win_exe_properties.o): Added rule to build the resource file. > > * configure: Add win_exe_properties.o to mingw32 specific > > objects. > > * common/create-win_exe_properties.sh: Shell script to > > create a win_exe_properties.h header file containing all > > information/defines for the gdb executable file properties. > > New file. > > * win_exe_properties.rc: Resource file implementing > > gdb executable file properties for windows/mingw32 builds. > > It includes auto-generated win_exe_properties.h file with > > property information. New file. >=20 > New files you add should say "New file". Also, please leave two spaces > between sentences, the US style. Ok, I will remove the text and only write "New file." for the 2 new files [= see next update]. >=20 > The GNU project doesn't like calling Windows a "win", so I suggest to > rename the files and the script to use something like mingw instead. Ok, I will rename it to mingw, since this change is only for mingw. (see also discsuion coming in a later email) >=20 > > +# check for environment variables to replace certain file properties > > +[ -n "$WIN_EXE_VERSION" ] && version=3D$WIN_EXE_VERSION [ -n > > +"$WIN_EXE_COMPANY_NAME" ] && company_name=3D$WIN_EXE_COMPANY_NAME > > +[ -n "$WIN_EXE_FILE_DESCRIPTION" ] && > > +file_description=3D$WIN_EXE_FILE_DESCRIPTION > > +[ -n "$WIN_EXE_PRODUCT_NAME" ] && product_name=3D$WIN_EXE_PRODUCT_NAME > > +[ -n "$WIN_EXE_INTERNAL_NAME" ] && > > +internal_name=3D$WIN_EXE_INTERNAL_NAME > > +[ -n "$WIN_EXE_ORIGINAL_FILENAME" ] && > > +original_filename=3D$WIN_EXE_ORIGINAL_FILENAME > > +[ -n "$WIN_EXE_COPYRIGHT" ] && copyright=3D$WIN_EXE_COPYRIGHT [ -n > > +"$WIN_EXE_LICENSE" ] && license=3D$WIN_EXE_LICENSE [ -n > > +"$WIN_EXE_CONFIGURED" ] && configured=3D$WIN_EXE_CONFIGURED [ -n > > +"$WIN_EXE_SUPPORT" ] && support=3D$WIN_EXE_SUPPORT >=20 > This looks like unnecessary featurism to me. Is it really needed, and > if so, in what use cases? Yes, it is needed. Not in here, but for every company which changes/adds an= d re-distributes gdb. I started this feature because our Product Validation does not like binarie= s without legal information. And off course this is different depending on who ships the product. Without a way to change the strings the complete changeset would be useless= for me. > > +#include "afxres.h" >=20 > Is this header really needed? Yes, unfortunately. This header file "implements" the resource language used below in the RC fi= le. >=20 > Thanks. Intel GmbH Dornacher Strasse 1 85622 Feldkirchen/Muenchen, Deutschland Sitz der Gesellschaft: Feldkirchen bei Muenchen Geschaeftsfuehrer: Christian Lamprechter, Hannes Schwaderer, Douglas Lusk Registergericht: Muenchen HRB 47456 Ust.-IdNr./VAT Registration No.: DE129385895 Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052