From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by sourceware.org (Postfix) with ESMTPS id 8B13C3857C62 for ; Mon, 14 Sep 2020 16:52:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 8B13C3857C62 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=undo.io Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mbarisione@undo.io Received: by mail-wr1-x443.google.com with SMTP id o5so335462wrn.13 for ; Mon, 14 Sep 2020 09:52:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=undo-io.20150623.gappssmtp.com; s=20150623; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=E3e2DqzCYlMWoiuxpx5Fj8CXJBuNuy0xgPQ2OwfYn6I=; b=HrUk0U4bzEsA9GjpPy2NYslY9s4YHG6f4JhKyoG7UrZHHQGY5N9L61Z7cZvxtmtHN9 niJjIRWxJJl3beVbofHUzhQJkyV0pohy/wWWdW2tatGwFJe9ejOuIzhAIHmIZ3ZR/IlM bvb3dRPPFfT3prcpCA/fNPK5idPu2mvePSjL+CjP4N9hdd05o+OD8UbCnEg5j0NU5JpJ xgzYOpoyzEr54iqPCT0Ckig4sE9i+hugFn1FdtRuvke9ruzJLBA9pObzDUqU7N7jPYoo WTGKMJ8k6rbcqIyXl7MKOryw8147qzesMsisBxHwFMBXA0BKHorq4tTxwr8E5dPM0Ii4 B6BQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=E3e2DqzCYlMWoiuxpx5Fj8CXJBuNuy0xgPQ2OwfYn6I=; b=sH23iElznkdI7CYNkU9H/yp/PyI5GFwbA3TK/X9xkheGSdnXGPNAsNWmdOCVS//Nmz ZZE0jH8dErV7qs22SFtKVYjWtsU05E9jjYl7IaxW8uAZzCAYB6QXkXA2x7pql4+jMJ3O dhhV3O4UzPvMsuwnsF0IJASrBxLAyAaHh4eQKLMUu18M+eic9A4pyObbP8BFWL3DwrFA zUVOujsM/r1m4JkxG59fxehMFS8T+ike+TQwmmdtcEWCRUQQtyOVscrX7CVee0XszdyI TKxar2nXV0R/QRJk7VytQ0vhEhS2e9qrrmuGYqQVvWyQ0S5dRLTEiFYDht0KcIAOywTg szqA== X-Gm-Message-State: AOAM532DIiQN8M0DoS1Xe33iqLNOOqEGgCNDR1Mgu87mu/+AZwX8tJBT 8nb3Xg06PxXZDl8BmVBHJQ7B2Q== X-Google-Smtp-Source: ABdhPJwh77WUYQptsi+SXl2I5oSCMCyAIbyISpmtc3W2NsS0M6WMQASlZcrX8srWNfQfjvxGkNHhNg== X-Received: by 2002:a5d:53d1:: with SMTP id a17mr16057871wrw.98.1600102319529; Mon, 14 Sep 2020 09:51:59 -0700 (PDT) Received: from [192.168.0.107] (cpc159317-cmbg20-2-0-cust117.5-4.cable.virginm.net. [81.111.29.118]) by smtp.gmail.com with ESMTPSA id h5sm21139897wrt.31.2020.09.14.09.51.58 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 14 Sep 2020 09:51:58 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.8\)) Subject: Re: [PATCH 2/2] Add a way to preserve redefined GDB commands for later invocation From: Marco Barisione In-Reply-To: <83lfhc9vsg.fsf@gnu.org> Date: Mon, 14 Sep 2020 17:51:57 +0100 Cc: gdb-patches@sourceware.org Content-Transfer-Encoding: 7bit Message-Id: References: <20200914093925.5442-1-mbarisione@undo.io> <20200914093925.5442-3-mbarisione@undo.io> <83lfhc9vsg.fsf@gnu.org> To: Eli Zaretskii X-Mailer: Apple Mail (2.3445.104.8) X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Sep 2020 16:52:01 -0000 On 14 Sep 2020, at 17:18, Eli Zaretskii wrote: > Thanks, the documentation parts are okay. > > Though I wonder whether 'uplevel' is really the best name for this. > (No, I don't write Python.) I do and I don't think it's immediately clear to the average Python developer but it's probably better to be consistent between Python and the command. I added "invoke_" to the name as it matches the existing gdb.Command.invoke method. Better suggestions welcome! :) -- Marco Barisione