Re: [PATCH] Fix a number of build problems found on Solaris and NetBSD (was Re: Oh dear. I regret to inform you that commit 0e65dfbaf3a0299e4837216a103c28625d4b4f1d might be unfortunate)

Kamil Rytarowski
2019-05-29T20:34:56Z

[-- Attachment #1.1: Type: text/plain, Size: 2343 bytes --]

On 29.05.2019 18:33, Nick Alcock wrote:
> On 29 May 2019, Rainer Orth stated:
>
>> Nix <nix@esperi.org.uk> writes:
>>> I stripped almost all of these out, but it looks like one single one
>>> survived. It is gone now.
>>
>> Thanks.
>
> If you'd like to try the entirely unreviewed patch I'm trying out (works
> for me on x86_64-pc-linux-gnu, i686-pc-linux-gnu, mingw, Solaris), here
> it is:
>

I wanted to check this patch on NetBSD but it does not apply for me for
some reason (I've used the original source of the mail as a patch).

Is it safe to use this off64_t define? Won't there be issues with off_t
that is 64-bit on NetBSD and 32-bit on some other OSs? NetBSD uses the
libctf stack from FreeBSD/SunOS for DTrace, will that be compatible with
this GDB code? Keeping CTF support is not the highest priority for us,
as we ship with DWARF.. but compatibility is good.

Feel free to apply this patch and it will be checked with the buildbot node.

$ cat /tmp/1.x |gpatch -p1
patching file include/ChangeLog
patching file include/ctf-api.h
patching file libctf/ChangeLog
Hunk #1 succeeded at 1 with fuzz 1.
patching file libctf/Makefile.am
patching file libctf/Makefile.in
patching file libctf/aclocal.m4
patching file libctf/config.h.in
Hunk #1 FAILED at 1.
Hunk #2 succeeded at 15 (offset -3 lines).
Hunk #3 succeeded at 94 (offset -3 lines).
1 out of 3 hunks FAILED -- saving rejects to file libctf/config.h.in.rej
patching file libctf/configure
Hunk #5 FAILED at 6139.
Hunk #6 succeeded at 6082 with fuzz 2 (offset -108 lines).
Hunk #7 succeeded at 6340 (offset -108 lines).
Hunk #8 succeeded at 6500 (offset -108 lines).
1 out of 8 hunks FAILED -- saving rejects to file libctf/configure.rej
patching file libctf/configure.ac
Hunk #1 FAILED at 56.
Hunk #2 FAILED at 86.
2 out of 2 hunks FAILED -- saving rejects to file libctf/configure.ac.rej
patching file libctf/ctf-archive.c
patching file libctf/ctf-create.c
patching file libctf/ctf-decls.h
patching file libctf/ctf-dump.c
patching file libctf/ctf-endian.h
patching file libctf/ctf-impl.h
patching file libctf/ctf-labels.c
patching file libctf/ctf-lookup.c
patching file libctf/ctf-open.c
patching file libctf/ctf-types.c
patching file libctf/ctf-util.c
patching file libctf/qsort_r.c
patching file libctf/swap.h

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]