Proposal to revert the gnulib update patch (was: Re: Breakage on builder RHEL-s390x-m64, revision 7a6dbc2fdb2323c35e981f93236f323e9d7c0b24)

Sergio Durigan Junior
2018-09-04T00:46:31Z

On Monday, September 03 2018, Jonah Graham wrote:

>> b) Is there a "stddef.h" file in the build dir? Does it declare
>> "max_align_t"? This is causing the "unknown type name ‘max_align_t’"
>> error.
>
> Our daily build (for Eclipse CDT testing) of GDB's master has started
> failing because of this issue too:
> https://ci.eclipse.org/cdt/job/debug-tests-master-gdb-master/1666/console

Thanks, Jonah.

I'm thinking about reverting the gnulib update patch. I'm on PTO this
week (in theory :-/), and not sure if I'll be able to address these
issues in a timely manner. Aside from this c11 issue, there's also the
mingw compilation failure.

Since the main reason for updating gnulib was to fix PR gdb/23558, as a
workaround, I propose that we backport just the upstream gnulib patch
that fixes the problem:

a96d2e67052c879b1bcc5bc461722beac75fc372

I'd like to hear your opinions.

Thanks,

--
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible