Breakage on builder Fedora-s390x-m64, revision f6ac5f3d63e03a81c4ff3749aba234961cc9090e

[gdb-buildbot@sergiodj.net]

Unfortunately it seems that there is a breakage on GDB.

Commit title: 'Convert struct target_ops to C++'
Revision: f6ac5f3d63e03a81c4ff3749aba234961cc9090e

You can find more details below:

+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+

Buildslave:
	marist-fedora-s390x

Full Build URL:
	<http://gdb-build.sergiodj.net/builders/Fedora-s390x-m64/builds/8386>

Commit(s) tested:
	f6ac5f3d63e03a81c4ff3749aba234961cc9090e

Author(s) (in the same order as the commits):
	Pedro Alves <palves@redhat.com>

Subject:
	Convert struct target_ops to C++

Testsuite log (gdb.sum and gdb.log) URL(s):
	<http://gdb-build.sergiodj.net/results/Fedora-s390x-m64/f6/f6ac5f3d63e03a81c4ff3749aba234961cc9090e/>

*** Failed to compiled GDB.  ***
============================

+++ The full log is too big to be posted here.
+++ These are the last 100 lines of it.

  CXX    sol2-tdep.o
  CXX    solib-aix.o
  CXX    solib-darwin.o
  CXX    solib-dsbt.o
  CXX    solib-frv.o
  CXX    solib-spu.o
  CXX    solib-svr4.o
  CXX    sparc-linux-tdep.o
  CXX    sparc-nbsd-tdep.o
  CXX    sparc-obsd-tdep.o
  CXX    sparc-ravenscar-thread.o
  CXX    sparc-sol2-tdep.o
  CXX    sparc-tdep.o
  CXX    spu-multiarch.o
  CXX    spu-tdep.o
  CXX    symfile-mem.o
  CXX    tic6x-linux-tdep.o
  CXX    tic6x-tdep.o
  CXX    tilegx-linux-tdep.o
  CXX    tilegx-tdep.o
  CXX    v850-tdep.o
  CXX    vax-nbsd-tdep.o
  CXX    vax-tdep.o
  CXX    windows-tdep.o
  CXX    x86-tdep.o
  CXX    xcoffread.o
  CXX    xstormy16-tdep.o
  CXX    xtensa-config.o
  CXX    xtensa-linux-tdep.o
  CXX    xtensa-tdep.o
  CXX    aarch64-fbsd-tdep.o
  CXX    aarch64-linux-tdep.o
  CXX    aarch64-newlib-tdep.o
  CXX    aarch64-tdep.o
  CXX    alpha-bsd-tdep.o
  CXX    alpha-linux-tdep.o
  CXX    alpha-mdebug-tdep.o
  CXX    alpha-nbsd-tdep.o
  CXX    alpha-obsd-tdep.o
  CXX    alpha-tdep.o
  CXX    amd64-darwin-tdep.o
  CXX    amd64-dicos-tdep.o
  CXX    amd64-fbsd-tdep.o
  CXX    amd64-linux-tdep.o
  CXX    amd64-nbsd-tdep.o
  CXX    amd64-obsd-tdep.o
  CXX    amd64-sol2-tdep.o
  CXX    amd64-tdep.o
  CXX    amd64-windows-tdep.o
  CXX    arch/aarch64.o
  CXX    arch/aarch64-insn.o
  CXX    arch/amd64.o
  CXX    ia64-linux-tdep.o
  CXX    ia64-tdep.o
  CXX    ia64-vms-tdep.o
  CXX    mips64-obsd-tdep.o
  CXX    sparc64-fbsd-tdep.o
  CXX    sparc64-linux-tdep.o
  CXX    sparc64-nbsd-tdep.o
  CXX    sparc64-obsd-tdep.o
  CXX    sparc64-sol2-tdep.o
  CXX    sparc64-tdep.o
  CXX    ser-base.o
  CXX    ser-unix.o
  CXX    ser-pipe.o
  CXX    ser-tcp.o
  CXX    inf-ptrace.o
  CXX    fork-child.o
  CXX    fork-inferior.o
  CXX    proc-service.o
  CXX    linux-thread-db.o
  CXX    linux-nat.o
  CXX    linux-osdata.o
  CXX    linux-fork.o
  CXX    linux-procfs.o
  CXX    linux-ptrace.o
  CXX    linux-waitpid.o
  CXX    linux-personality.o
  CXX    linux-namespaces.o
  CXX    s390-linux-nat.o
  CXX    cli/cli-cmds.o
../../binutils-gdb/gdb/s390-linux-nat.c:125:7: error: conflicting return type specified for virtual int s390_linux_nat_target::have_continuable_watchpoint()
   int have_continuable_watchpoint () { return 1; }
       ^~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ../../binutils-gdb/gdb/inferior.h:40:0,
                 from ../../binutils-gdb/gdb/s390-linux-nat.c:24:
../../binutils-gdb/gdb/target.h:534:18: error:   overriding virtual bool target_ops::have_continuable_watchpoint()
     virtual bool have_continuable_watchpoint ()
                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~
../../binutils-gdb/gdb/s390-linux-nat.c:125:7: error: virtual int s390_linux_nat_target::have_continuable_watchpoint() can be marked override [-Werror=suggest-override]
   int have_continuable_watchpoint () { return 1; }
       ^~~~~~~~~~~~~~~~~~~~~~~~~~~
cc1plus: all warnings being treated as errors
make[2]: *** [Makefile:1613: s390-linux-nat.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[2]: Leaving directory '/home/mjw/gdb/build/fedora-s390x/build/gdb'
make[1]: *** [Makefile:8793: all-gdb] Error 2
make[1]: Leaving directory '/home/mjw/gdb/build/fedora-s390x/build'
make: *** [Makefile:850: all] Error 2
============================