From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26146 invoked by alias); 9 Nov 2013 06:23:54 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 26133 invoked by uid 89); 9 Nov 2013 06:23:53 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=2.3 required=5.0 tests=BAYES_00,DATE_IN_PAST_96_XX,FREEMAIL_FROM,RDNS_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no version=3.3.2 X-HELO: mail-qc0-f174.google.com Received: from Unknown (HELO mail-qc0-f174.google.com) (209.85.216.174) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Sat, 09 Nov 2013 06:23:51 +0000 Received: by mail-qc0-f174.google.com with SMTP id v1so2590156qcw.33 for ; Fri, 08 Nov 2013 22:23:43 -0800 (PST) X-Received: by 10.49.98.100 with SMTP id eh4mr28516445qeb.42.1383978223663; Fri, 08 Nov 2013 22:23:43 -0800 (PST) Received: from hydrogen (naesten-pt.tunnel.tserv4.nyc4.ipv6.he.net. [2001:470:1f06:57::2]) by mx.google.com with ESMTPSA id n7sm31240003qai.1.2013.11.08.22.23.41 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Fri, 08 Nov 2013 22:23:42 -0800 (PST) Received: from naesten by hydrogen with local (Exim 4.80) (envelope-from ) id 1Vf1xJ-0002Ya-T4; Sat, 09 Nov 2013 01:23:38 -0500 In-Reply-To: <1383519137-26388-1-git-send-email-naesten@gmail.com> References: <1383519137-26388-1-git-send-email-naesten@gmail.com> From: Samuel Bronson Date: Sat, 09 Nov 2013 18:41:00 -0000 Subject: [PATCH v3] Resurrect gdb-add-index as a contrib script To: gdb-patches@sourceware.org Cc: Tom Tromey , Jan Kratochvil , Doug Evans Message-Id: X-IsSubscribed: yes X-SW-Source: 2013-11/txt/msg00256.txt.bz2 This includes some changes made in Fedora's gdb packaging[1], and Doug's robustness patch[2] from before it was dropped (with some slight corrections). [1]: http://pkgs.fedoraproject.org/cgit/gdb.git/log/gdb-gdb-add-index-script.patch?id=fe74423b0812bae6d7bb027584e401a2ac37d24d [2]: https://sourceware.org/ml/gdb-patches/2010-09/msg00130.html I'm including a log of relevant previous activity. (I would just include committishes, but I'm not quite confident that history won't be rewritten again, invalidating the hashes, plus there are no relevant tags so the first two parts of git-describe(1) output wouldn't be any help either.) commit 97924a976b7d6e1669cf22c5fdf292a53bae6bd0 Author: Tom Tromey Date: Tue Nov 16 17:38:40 2010 +0000 * gdb-add-index.sh: Really remove. gdb/ChangeLog | 4 ++++ gdb/gdb-add-index.sh | 29 ----------------------------- 2 files changed, 4 insertions(+), 29 deletions(-) commit c29c521f43a1f470355cc76391bb10ec2b73284a Author: Tom Tromey Date: Tue Aug 10 18:35:53 2010 +0000 gdb Revert gdb-add-index addition: * Makefile.in (install-only): Don't install gdb-add-index. * gdb-add-index.sh: Remove. gdb/doc Revert gdb-add-index addition: * gdb.texinfo (Index Files): Don't document gdb-add-index. gdb/ChangeLog | 6 ++++++ gdb/Makefile.in | 11 +---------- gdb/doc/ChangeLog | 5 +++++ gdb/doc/gdb.texinfo | 10 ---------- 4 files changed, 12 insertions(+), 20 deletions(-) commit c2bbed2a5ab3c5c5950ef192f9be610a11aaa367 Author: Tom Tromey Date: Fri Jul 30 20:46:34 2010 +0000 gdb * Makefile.in (install-only): Install gdb-add-index. * gdb-add-index.sh: New file. gdb/doc * gdb.texinfo (Index Files): Mention gdb-add-index. gdb/ChangeLog | 5 +++++ gdb/Makefile.in | 11 ++++++++++- gdb/doc/ChangeLog | 4 ++++ gdb/doc/gdb.texinfo | 9 +++++++++ gdb/gdb-add-index.sh | 29 +++++++++++++++++++++++++++++ 5 files changed, 57 insertions(+), 1 deletion(-) --- gdb/ChangeLog | 8 ++++++ gdb/contrib/gdb-add-index.sh | 61 ++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 69 insertions(+) create mode 100755 gdb/contrib/gdb-add-index.sh diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 79abe3d..def36a3 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,11 @@ +2013-11-08 Tom Tromey + Jan Kratochvil + Doug Evans + Samuel Bronson + + Bring back gdb-add-index as a contrib script. + * contrib/gdb-add-index.sh: New file. + 2013-11-08 Doug Evans * dwarf2read.c (dwarf2_read_debug): Change to unsigned int. diff --git a/gdb/contrib/gdb-add-index.sh b/gdb/contrib/gdb-add-index.sh new file mode 100755 index 0000000..437e8c4 --- /dev/null +++ b/gdb/contrib/gdb-add-index.sh @@ -0,0 +1,61 @@ +#! /bin/sh + +# Add a .gdb_index section to a file. + +# Copyright (C) 2010, 2012-2013 Free Software Foundation, Inc. +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 3 of the License, or +# (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program. If not, see . + +# This program assumes gdb and objcopy are in $PATH. + +myname="${0##*/}" + +if test $# != 1; then + echo "usage: $myname FILE" 1>&2 + exit 1 +fi + +file="$1" + +if test ! -r "$file"; then + echo "$myname: unable to access: $file" 1>&2 + exit 1 +fi + +dir="${file%/*}" +test "$dir" = "$file" && dir="." +index="${file}.gdb-index" + +# Ensure intermediate index file is removed when we exit. +trap "rm -f $index" 0 + +gdb --batch-silent -nx -iex 'set auto-load no' \ + -ex "file $file" -ex "save gdb-index $dir" || { + # Just in case. + status=$? + echo "$myname: gdb error generating index" 1>&2 + exit $status +} + +# In some situations gdb can exit without creating an index. This is +# not an error. +# E.g., if $file is stripped. This behaviour is akin to stripping an +# already stripped binary, it's a no-op. + +if test -f "$index"; then + objcopy --add-section .gdb_index="$index" \ + --set-section-flags .gdb_index=readonly "$file" "$file" + status=$? +fi + +exit $status -- 1.8.4.rc3