From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-86950-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 22781 invoked by alias); 11 Jan 2012 10:16:43 -0000
Received: (qmail 22773 invoked by uid 22791); 11 Jan 2012 10:16:42 -0000
X-SWARE-Spam-Status: No, hits=-2.2 required=5.0	tests=AWL,BAYES_00,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from fencepost.gnu.org (HELO fencepost.gnu.org) (140.186.70.10)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 11 Jan 2012 10:16:28 +0000
Received: from eliz by fencepost.gnu.org with local (Exim 4.71)	(envelope-from <eliz@gnu.org>)	id 1RkvEJ-0001cT-Ck; Wed, 11 Jan 2012 05:16:27 -0500
Date: Wed, 11 Jan 2012 10:27:00 -0000
Message-Id: <E1RkvEJ-0001cT-Ck@fencepost.gnu.org>
From: Eli Zaretskii <eliz@gnu.org>
To: Kevin Pouget <kevin.pouget@gmail.com>
CC: gdb-patches@sourceware.org, pmuldoon@redhat.com
In-reply-to:	<CAPftXULz7MiuBzdxDiQ1HPfyty+K2eW4xfUHNVv8cH77M-dKHg@mail.gmail.com>	(message from Kevin Pouget on Wed, 11 Jan 2012 10:47:55 +0100)
Subject: Re: [PATCH] Add bp_location to Python interface
Reply-to: Eli Zaretskii <eliz@gnu.org>
References: <CAPftXUL7Gag8pOzh6NF2t=nowBgSYa_Je3CkMQHgxexrNz+OHg@mail.gmail.com> <m3liqn9lym.fsf@redhat.com> <CAPftXULeNBNLT=9EixD3sEdtxcLkRuUFY6ny=2k9NSUQqHf+Bg@mail.gmail.com> <m3k4656dkx.fsf@redhat.com> <CAPftXU+NjNead1ZHEc8_P84py3esmOnAKVa2Y1KpxKX_augKsw@mail.gmail.com> <CAPftXUL6KTe-WEFnWR38pVnGUJhmEQgZ0J7R7heeR3GHtmrf5g@mail.gmail.com> <83r4z8eqoa.fsf@gnu.org> <CAPftXULwT9pTagJOzVsDjtdFkcoFwTWm3gs0=a=EYzMbZYHPgA@mail.gmail.com> <83k44zeaui.fsf@gnu.org> <CAPftXULz7MiuBzdxDiQ1HPfyty+K2eW4xfUHNVv8cH77M-dKHg@mail.gmail.com>
MIME-version: 1.0
Content-type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8bit
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2012-01/txt/msg00347.txt.bz2

> From: Kevin Pouget <kevin.pouget@gmail.com>
> Date: Wed, 11 Jan 2012 10:47:55 +0100
> Cc: gdb-patches@sourceware.org, pmuldoon@redhat.com
> 
> >> +Return a tuple containing a sequence of @code{gdb.BpLocation} objects
> >> +(see below) associated with this breakpoint.  A breakpoint with no location
> >> +is a pending breakpoint (@xref{Set Breaks, , pending breakpoints}).
> >                            ^^^^^
> > Still an @xref...
> 
> sorry, I missed it in the first run ...

See below, it sounds like I totally failed to explain myself in this
matter.

> +@defun gdb.locations ()
> +Return a tuple containing a sequence of @code{gdb.BpLocation} objects 
> +(see below) associated with this breakpoint.  A breakpoint with no location
> +is a pending breakpoint (@xref{Set Breaks, , pending breakpoints}).

This @xref should become @pxref, because the cross reference is in
parentheses (that's the `p' part of `pxref') and is not a complete
sentence.

The other @xref that you changed to @pxref should be left alone.

> -become invisible to the user.  @xref{Breakpoints In Python}, for further 
> +become invisible to the user.  @pxref{Breakpoints In Python}, for further 
>  details about this argument.

This should be @xref, as it is not in parentheses and is a complete
sentence.

Thanks, and sorry for my evidently unclear wording.