From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-86072-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 31966 invoked by alias); 13 Dec 2011 08:17:27 -0000
Received: (qmail 31939 invoked by uid 22791); 13 Dec 2011 08:17:24 -0000
X-SWARE-Spam-Status: No, hits=-3.3 required=5.0	tests=AWL,BAYES_00,RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from fencepost.gnu.org (HELO fencepost.gnu.org) (140.186.70.10)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 13 Dec 2011 08:17:11 +0000
Received: from eliz by fencepost.gnu.org with local (Exim 4.71)	(envelope-from <eliz@gnu.org>)	id 1RaNXy-0000mg-1J; Tue, 13 Dec 2011 03:17:10 -0500
Date: Tue, 13 Dec 2011 12:36:00 -0000
Message-Id: <E1RaNXy-0000mg-1J@fencepost.gnu.org>
From: Eli Zaretskii <eliz@gnu.org>
To: Mark Kettenis <mark.kettenis@xs4all.nl>
CC: andrew.smirnov@gmail.com, gdb-patches@sourceware.org,	andrew.smirnov@gmail.com
In-reply-to: <201112130717.pBD7Hcdp009062@glazunov.sibelius.xs4all.nl>	(message from Mark Kettenis on Tue, 13 Dec 2011 08:17:38 +0100 (CET))
Subject: Re: [PATCH 036/238] [index] i386-tdep.c: -Wshadow fix
Reply-to: Eli Zaretskii <eliz@gnu.org>
References: <1323747545-29987-1-git-send-email-andrew.smirnov@gmail.com> <1323747545-29987-2-git-send-email-andrew.smirnov@gmail.com> <201112130717.pBD7Hcdp009062@glazunov.sibelius.xs4all.nl>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2011-12/txt/msg00391.txt.bz2

> Date: Tue, 13 Dec 2011 08:17:38 +0100 (CET)
> From: Mark Kettenis <mark.kettenis@xs4all.nl>
> CC: gdb-patches@sourceware.org, andrew.smirnov@gmail.com
> 
> > From: Andrey Smirnov <andrew.smirnov@gmail.com>
> > Date: Mon, 12 Dec 2011 19:38:39 -0800
> > 
> > To ChangeLog:
> > 	* i386-tdep.c (i386_record_lea_modrm_addr): Rename `index' to
> > 	`idx'(-Wshadow).
> > ---
> >  gdb/i386-tdep.c |    8 ++++----
> >  1 files changed, 4 insertions(+), 4 deletions(-)
> 
> My position on this is unchanged.  I think 'index' is a perfectly good
> variable name

And `idx' is its extremely popular synonym.

How much of personal preferences should area maintainers force on
contributors, just because they can?