Re: [PATCH 18/348] Fix -Wsahdow warnings

Joel Brobecker
2011-11-25T14:26:38Z

> Thanks for bringing that up, that is, IMHO, an excellent example.
> The `block_found' in function conflicts with global variable declared
> in symtab.c and it is not that just their names match, types are very
> similar too one is `struct block **' another is `const struct *block'.

Hmmm, I don't know how I missed that, as I grep'ed the source code.
Or so I thought. Maybe a typo.

In this particular case, yes, I agree, we should do something. We might
prefer to rename the global variable, though; I think that a global
variable with that name is bizarre.

As to the final decision of enabling -Wshadow by default, I agree
a little more to the idea, although not quite convinced yet. So far,
Eli is pro. Mark is against. I'm 50/50. Unless we get more feedback
from other GMs, you've done the work, we could at least try it and
see where that gets us.

--
Joel