Re: [PATCH 18/348] Fix -Wsahdow warnings

Ulrich Weigand
2011-11-23T16:41:09Z

Mark Kettenis wrote:

> > From: Andrey Smirnov <andrew.smirnov@gmail.com>
> > Date: Tue, 22 Nov 2011 17:25:56 +0700
> > Subject: [PATCH 18/39] Fix -Wshadow warnings.
> >
> > * amd64-linux-tdep.c (amd64_canonicalize_syscall): Fix -Wshadow
> > warnings.
>
> Why the hell does -Wshadow complain here?

> > -amd64_canonicalize_syscall (enum amd64_syscall syscall)
> > +amd64_canonicalize_syscall (enum amd64_syscall syscall_number)

I'd expect this is because the parameter "syscall" shadows the global
function declaration "syscall" provided by glibc headers:

/usr/include/unistd.h:extern long int syscall (long int __sysno, ...) __THROW;

Bye,
Ulrich

--
Dr. Ulrich Weigand
GNU Toolchain for Linux on System z and Cell BE
Ulrich.Weigand@de.ibm.com