From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31661 invoked by alias); 8 Nov 2011 08:20:54 -0000 Received: (qmail 31648 invoked by uid 22791); 8 Nov 2011 08:20:51 -0000 X-SWARE-Spam-Status: No, hits=-2.7 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from fencepost.gnu.org (HELO fencepost.gnu.org) (140.186.70.10) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 08 Nov 2011 08:20:36 +0000 Received: from eliz by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1RNgv4-0007F7-JD; Tue, 08 Nov 2011 03:20:34 -0500 Date: Tue, 08 Nov 2011 08:20:00 -0000 Message-Id: From: Eli Zaretskii To: Yao Qi CC: gdb-patches@sourceware.org In-reply-to: <4EB8CEC4.9000905@codesourcery.com> (message from Yao Qi on Tue, 08 Nov 2011 14:40:04 +0800) Subject: Re: [patch 6/8] gdbserver - Install tracepoint when tracing is running Reply-to: Eli Zaretskii References: <4EB8C551.9090609@codesourcery.com> <4EB8CEC4.9000905@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-11/txt/msg00181.txt.bz2 > Date: Tue, 08 Nov 2011 14:40:04 +0800 > From: Yao Qi > > -/* Create a tracepoint (location) with given number and address. */ > +/* Create a tracepoint (location) with given number and address. If SORT is > + non-zero, the list of tracepoint will be sorted. */ ^^^^^^^^^^ "tracepoints" > + /* Find a place to insert this tracepoint into list in order to keep > + the tracepoint list still in an ascending order. There may be ^^^^^^^^^^^^^^^^^^ "the ascending order" > + multiple tracepoints at the same address as TPOINT's, and this > + guarantee that TP_PREV is the last tracepoint entry of them, so that ^^^^^^^^^ "guarantees" > + TPOINT is inserted at the last of them. "inserted at the last of them" is not clear. I would suggest using "before" or "after". Or maybe "at the highest address" if you mean "at address" (I don't really understand the meaning of what the code does.) > For example, fast tracepoint "tracepoints" > + /* Install tracepoint during tracing only once of each tracepoint location. ^^^^^^^ "for each", I think. > + /* Find the previous entry of TPOINT, which is fast tracepoint or > + or static tracepoint. */ 2 "or" in a row. Thanks.