From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-84622-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 3348 invoked by alias); 24 Oct 2011 13:01:03 -0000
Received: (qmail 3333 invoked by uid 22791); 24 Oct 2011 13:01:02 -0000
X-SWARE-Spam-Status: No, hits=-1.4 required=5.0	tests=AWL,BAYES_40,RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from fencepost.gnu.org (HELO fencepost.gnu.org) (140.186.70.10)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 24 Oct 2011 13:00:45 +0000
Received: from eliz by fencepost.gnu.org with local (Exim 4.71)	(envelope-from <eliz@gnu.org>)	id 1RIK8y-0002Nm-AJ; Mon, 24 Oct 2011 09:00:44 -0400
Date: Mon, 24 Oct 2011 13:20:00 -0000
Message-Id: <E1RIK8y-0002Nm-AJ@fencepost.gnu.org>
From: Eli Zaretskii <eliz@gnu.org>
To: Kevin Pouget <kevin.pouget@gmail.com>
CC: tromey@redhat.com, gdb-patches@sourceware.org
In-reply-to:	<CAPftXUKsSSb=36CQ+ptGenkt4Q167TtJXuDD2fkU7KFYDu_tPQ@mail.gmail.com>	(message from Kevin Pouget on Mon, 24 Oct 2011 11:14:42 +0200)
Subject: Re: [RFC] Python Finish Breakpoints
Reply-to: Eli Zaretskii <eliz@gnu.org>
References: <BANLkTim+YH64zkWvdz2_kVUUj=AJ7v4LKw@mail.gmail.com> <BANLkTi=Eu-5B4YyhP2rGdQXgXbBN-EmLKA@mail.gmail.com> <BANLkTikt2hEUcXkGVH44NaUcwiF1SGdMaw@mail.gmail.com> <BANLkTi=UpgogckTD5MZsW+PC5d2F8X-+jA@mail.gmail.com> <BANLkTi==bj50mZgFKq_qA-+3-2CQA3tBVw@mail.gmail.com> <BANLkTimmYEmvKT_984jYEVZnA5RGFpEgNw@mail.gmail.com> <m34o4qd5lh.fsf@fleche.redhat.com> <BANLkTinZ3DSVPRvSiFydCuYs71-DM5-aOg@mail.gmail.com> <m3vcwvubry.fsf@fleche.redhat.com> <BANLkTinBg76_-9i5n=VA2NXp+ZF978J=ig@mail.gmail.com> <m3y5wfl7ky.fsf@fleche.redhat.com> <CAPftXUKHxpww_pEcsMruR6rqo40xw9q9Jzn65-dXys_COt6JbQ@mail.gmail.com> <CAPftXUKsSSb=36CQ+ptGenkt4Q167TtJXuDD2fkU7KFYDu_tPQ@mail.gmail.com>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2011-10/txt/msg00625.txt.bz2

> From: Kevin Pouget <kevin.pouget@gmail.com>
> Date: Mon, 24 Oct 2011 11:14:42 +0200
> Cc: gdb-patches@sourceware.org
> 
> I've updated the doc and testsuite accordingly, and as far as I've
> seen, there is no regression on X86_64/Fedora
> (I need still need to improve my test environment)

Thanks.

> +@subsubsection Finish Breakpoints
> +
> +@cindex python finish breakpoints
> +@tindex gdb.FinishBreakpoint

No @node?  Why not?

> +extends @code{gdb.Breakpoint}. The underlying breakpoint will be disabled 
                                                 ^^^^^^^^^^
A typo.

> +and deleted when the execution will run out of the breakoint scope (i.e.@: 
                                                      ^^^^^^^^^
Another one.

> +breakpoint to become invisible to the user.  @xref{Breakpoints In Python}
> +for further details about this argument.

You need a comma after the braces (didn't "make info" bitch at you?).

> +In some circonstances (e.g.@: @code{longjmp}, C++ exceptions, @value{GDBN} 
           ^^^^^^^^^^^^^
A typo.  Also, we use "C@{++}" throughout the document, it looks
prettier in print.

> +@code{return} command, ...), a function may not properly terminate, and thus
                          ^^^
Please use @dots{} here instead of literal dots.
 
> +was not computable. This attribute is not writable.

Two blanks, please.

Okay with these changes.