From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30878 invoked by alias); 4 Oct 2011 09:29:34 -0000 Received: (qmail 30869 invoked by uid 22791); 4 Oct 2011 09:29:33 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from fencepost.gnu.org (HELO fencepost.gnu.org) (140.186.70.10) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 04 Oct 2011 09:29:19 +0000 Received: from eliz by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1RB1JO-0007S1-ES for gdb-patches@sourceware.org; Tue, 04 Oct 2011 05:29:18 -0400 Date: Tue, 04 Oct 2011 09:29:00 -0000 Message-Id: From: Eli Zaretskii To: gdb-patches@sourceware.org In-reply-to: <20111004075325.GB13895@calimero.vinschen.de> (message from Corinna Vinschen on Tue, 4 Oct 2011 09:53:26 +0200) Subject: Re: [RFA] Environment variables passed to inferior by MinGW build (PR 10989) Reply-to: Eli Zaretskii References: <4E7FBF9E.20000@earthlink.net> <20110926171511.GJ17681@adacore.com> <20111004075325.GB13895@calimero.vinschen.de> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-10/txt/msg00066.txt.bz2 > Date: Tue, 4 Oct 2011 09:53:26 +0200 > From: Corinna Vinschen > Reply-To: gdb-patches@sourceware.org > > I was on vacation and I'm also not the area maintainer for windows-nat.c. No worries, I hope you had a good time ;-) I CC'ed you because you made the change that I partially undid, and also participated in some of the discussions I cited. > Eli's patch is ok, IMHO, but it's a pity that Pierre never followed up > to http://sourceware.org/ml/gdb-patches/2011-04/msg00351.html since that > means that now setting environment variables works in Mingw, but not in > Cygwin. Could you elaborate why the behavior on Cygwin is incorrect? AFAICT, Pierre's changes didn't get into GDB, so GDB still works as it did before, and your changes that introduced the call to cygwin_internal were supposed to fix the issue of "set environment" and "unset environment", right? Not that I understand exactly what cygwin_internal does in that case and how it works. > So, as far as I can see, PR #10989 should not have been closed > yet. But that bug report is for the MinGW host and target only, so if Cygwin has a similar problem, it's a different issue and probably also a different solution. OTOH, if the same code I re-introduced will work for Cygwin, it should be a simple matter to remove the #if conditionals. Am I missing something?