From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9894 invoked by alias); 2 May 2011 14:35:08 -0000 Received: (qmail 9785 invoked by uid 22791); 2 May 2011 14:35:06 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from fencepost.gnu.org (HELO fencepost.gnu.org) (140.186.70.10) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 02 May 2011 14:34:52 +0000 Received: from eliz by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1QGuD5-0002BT-LG; Mon, 02 May 2011 10:34:51 -0400 Date: Mon, 02 May 2011 14:35:00 -0000 Message-Id: From: Eli Zaretskii To: Jan Kratochvil CC: gdb-patches@sourceware.org In-reply-to: <20110502141121.GA19958@host1.jankratochvil.net> (message from Jan Kratochvil on Mon, 2 May 2011 16:11:21 +0200) Subject: Re: [patch 4/3] readline-6.2: Substitute inc-hist.texinfo Reply-to: Eli Zaretskii References: <20110502141121.GA19958@host1.jankratochvil.net> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-05/txt/msg00012.txt.bz2 > Date: Mon, 2 May 2011 16:11:21 +0200 > From: Jan Kratochvil > > Used slightly alternative one with IMO better reference and I have also kept > hsuser.texi in place as readline/ in src/ is no longer a standalone readline > distribution anyway. Thanks. However,... > --- a/readline/doc/hsuser.texi > +++ b/readline/doc/hsuser.texi > @@ -26,9 +26,10 @@ into another language, under the above conditions for modified versions. > @node Using History Interactively > @chapter Using History Interactively > > -@ifclear BashFeatures > -@defcodeindex bt > -@end ifclear > +@c GDB bundling modification: > +@c @ifclear BashFeatures > +@c @defcodeindex bt > +@c @end ifclear Why do we need to comment this out? If BashFeatures is not set, the @defcodeindex line will not be in effect anyway. Is something setting BashFeatures anywhere when we build our docs? > This chapter describes how to use the @sc{gnu} History Library interactively, > from a user's standpoint. It should be considered a user's guide. For > information on using the @sc{gnu} History Library in your own programs, > -@pxref{Programming with GNU History}. > +@c GDB bundling modification: > +@pxref{Programming with GNU History, , , history, GNU History Library}. > @end ifclear Is this because the referenced node is only in the separate history.info manual, which is not part of hsuser.texi? If so, this is actually a bug in Readline docs which should be fixed upstream in a way that allows any project to include hsuser.texi without making such changes. For example: @ifset HsUser @pxref{Programming with GNU History, , , history, GNU History Library}. @end ifset @ifclear HsUser @pxref{Programming with GNU History}. @end ifclear Then projects that include just hsuser.texi will need to pass the "-DHsUser" switch to makeinfo, while Readline will not. I'm okay with making these changes for now, to allow people building GDB without failures. But if Chet accepts the above change, we should switch to it in GDB, so that our doc/Makefile.in is ready for the next upstream release of Readline.