From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26931 invoked by alias); 14 Mar 2011 12:52:57 -0000 Received: (qmail 26923 invoked by uid 22791); 14 Mar 2011 12:52:56 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from fencepost.gnu.org (HELO fencepost.gnu.org) (140.186.70.10) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 14 Mar 2011 12:52:53 +0000 Received: from eliz by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1Pz7GV-0008AV-E5; Mon, 14 Mar 2011 08:52:51 -0400 Date: Mon, 14 Mar 2011 13:06:00 -0000 Message-Id: From: Eli Zaretskii To: "Pierre Muller" CC: pedro@codesourcery.com, gdb-patches@sourceware.org In-reply-to: <000601cbe244$22256280$66702780$@muller@ics-cnrs.unistra.fr> (pierre.muller@ics-cnrs.unistra.fr) Subject: Re: New ARI warning Sat Mar 12 01:53:29 UTC 2011 Reply-to: Eli Zaretskii References: <20110312015329.GA20179@sourceware.org> <006701cbe220$a1a8dba0$e4fa92e0$@muller@ics-cnrs.unistra.fr> <201103141213.43979.pedro@codesourcery.com> <000601cbe244$22256280$66702780$@muller@ics-cnrs.unistra.fr> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-03/txt/msg00719.txt.bz2 > From: "Pierre Muller" > Date: Mon, 14 Mar 2011 13:34:16 +0100 > > > "A function declaration should not have its name in column zero. A > > function definition should have its name in column zero." > > Thank you for finding this out... > This is clearer than what I try to explain to Eli before. > > Eli, do you agree with this statement > in gdbint.textinfo or should it be modified? That sentence says what one should _not_ do. The issue in this thread is what to do instead. > Would you like to enhance it to specify what to do if > the whole function declaration > TYPE NAME (PARAMS); > doesn't fit into a 80 columns line? > > I am willing to adapt the ARI rule to such recommendations. I suggested how to format that case. If that suggestion is accepted, I will change gdbint.texinfo accordingly.