Re: New ARI warning Sat Mar 12 01:53:29 UTC 2011

Pedro Alves
2011-03-14T13:16:29Z

On Monday 14 March 2011 13:06:08, Eli Zaretskii wrote:
> > I'm fine with your suggestion, and in fact it's my preference
> > as well. However, there are cases where you just can't do that,
> > because the return type + function name + parameter end up being
> > too long for a single line.
>
> What's wrong with leaving a single long line in such cases? They are
> supposed to be very rare (if typedefs are used for complex function
> arguments).

If we have a rule to follow, we should follow it everywhere.
And they are not very rare; we have quite a few cases. The most
prominent styles are:

/* Find a particular location expression from a location list. */
const gdb_byte *dwarf2_find_location_expression
(struct dwarf2_loclist_baton *baton,
size_t *locexpr_length,
CORE_ADDR pc);

/* Find an inferior bound to PSPACE. */
extern struct inferior *
find_inferior_for_program_space (struct program_space *pspace);

--
Pedro Alves