From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-79603-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 17692 invoked by alias); 14 Mar 2011 12:34:55 -0000
Received: (qmail 17684 invoked by uid 22791); 14 Mar 2011 12:34:55 -0000
X-SWARE-Spam-Status: No, hits=-2.0 required=5.0	tests=AWL,BAYES_00,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from fencepost.gnu.org (HELO fencepost.gnu.org) (140.186.70.10)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 14 Mar 2011 12:34:51 +0000
Received: from eliz by fencepost.gnu.org with local (Exim 4.71)	(envelope-from <eliz@gnu.org>)	id 1Pz6z3-0006vZ-Cl; Mon, 14 Mar 2011 08:34:49 -0400
Date: Mon, 14 Mar 2011 12:51:00 -0000
Message-Id: <E1Pz6z3-0006vZ-Cl@fencepost.gnu.org>
From: Eli Zaretskii <eliz@gnu.org>
To: Pedro Alves <pedro@codesourcery.com>
CC: gdb-patches@sourceware.org, pierre.muller@ics-cnrs.unistra.fr
In-reply-to: <201103141213.43979.pedro@codesourcery.com> (message from Pedro	Alves on Mon, 14 Mar 2011 12:13:43 +0000)
Subject: Re: New ARI warning Sat Mar 12 01:53:29 UTC 2011
Reply-to: Eli Zaretskii <eliz@gnu.org>
References: <20110312015329.GA20179@sourceware.org> <006701cbe220$a1a8dba0$e4fa92e0$@muller@ics-cnrs.unistra.fr> <E1Pz5v6-0002FS-Es@fencepost.gnu.org> <201103141213.43979.pedro@codesourcery.com>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2011-03/txt/msg00716.txt.bz2

> From: Pedro Alves <pedro@codesourcery.com>
> Date: Mon, 14 Mar 2011 12:13:43 +0000
> Cc: "Pierre Muller" <pierre.muller@ics-cnrs.unistra.fr>
> 
> "A function declaration should not have its name in column zero.  A
> function definition should have its name in column zero."

At the very least, please reformat the prototypes like this:

extern whatever_type foo (type1_t,
       		     	  type2_t, const char **, foobar_t);

not like Pierre originally suggested.

That is, let the left paren and at least one argument be on the same
line as the function name.