From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28475 invoked by alias); 14 Mar 2011 12:32:16 -0000 Received: (qmail 28467 invoked by uid 22791); 14 Mar 2011 12:32:15 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from fencepost.gnu.org (HELO fencepost.gnu.org) (140.186.70.10) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 14 Mar 2011 12:32:09 +0000 Received: from eliz by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1Pz6wR-0006nh-7n; Mon, 14 Mar 2011 08:32:07 -0400 Date: Mon, 14 Mar 2011 12:34:00 -0000 Message-Id: From: Eli Zaretskii To: Pedro Alves CC: gdb-patches@sourceware.org, pierre.muller@ics-cnrs.unistra.fr In-reply-to: <201103141213.43979.pedro@codesourcery.com> (message from Pedro Alves on Mon, 14 Mar 2011 12:13:43 +0000) Subject: Re: New ARI warning Sat Mar 12 01:53:29 UTC 2011 Reply-to: Eli Zaretskii References: <20110312015329.GA20179@sourceware.org> <006701cbe220$a1a8dba0$e4fa92e0$@muller@ics-cnrs.unistra.fr> <201103141213.43979.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-03/txt/msg00714.txt.bz2 > From: Pedro Alves > Date: Mon, 14 Mar 2011 12:13:43 +0000 > Cc: "Pierre Muller" > > On Monday 14 March 2011 11:26:40, Eli Zaretskii wrote: > > > Would it be better to reformat those as > > > extern TYPE long_func_name > > > (with_long_parameters); > > > instead of > > > extern TYPE > > > long_func_name (with_long_parameters); > > > > No, that's even uglier. > > > > But it's what we do all over. We do have the rule that > grep "^foofunc" should only match function definitions, not > declarations. Here in gdbint.texinfo: > > "A function declaration should not have its name in column zero. A > function definition should have its name in column zero." What can I say? it's ugly.