Re: [patch libiberty include]: Add additional helper functions for directory-separator searching

Eli Zaretskii
2011-03-08T18:39:56Z

> From: Pedro Alves <pedro@codesourcery.com>
> Date: Tue, 8 Mar 2011 13:33:02 +0000
> Cc: Kai Tietz <ktietz70@googlemail.com>,
> gcc-patches@gcc.gnu.org,
> Eli Zaretskii <eliz@gnu.org>,
> binutils@sourceware.org
>
> On Tuesday 08 March 2011 12:48:11, Kai Tietz wrote:
>
> > Well, a better example is elfstab_offset_sections() in elfread.c.
>
> /* The ELF symbol info doesn't include path names, so strip the path
> (if any) from the psymtab filename. */
> while (0 != (p = strchr (filename, '/')))
> filename = p + 1;
>
> Looks like its looking for the last path separator, so
> it might as well use filename_dirrchr instead.

Exactly.

> > Another is in find_file_and_directory() in dwarf2read.c file.
>
> Workaround for Irix. Certainly that '/' should not depend
> on the host gdb is running on.

It actually should use IS_ABSOLUTE_FILE_NAME, if any portability
enhancement is needed here.

In my experience, the strchr analog is not needed, only the strrchr
one (which could be used quite a lot). The few places that use strchr
now should actually be rewritten to search from the end, because
that's what they need.