Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Doug Evans <dje@google.com>
Cc: jan.kratochvil@redhat.com, gdb-patches@sourceware.org
Subject: Re: [patch, doc RFA] New command-line option -na.
Date: Wed, 15 Dec 2010 06:05:00 -0000	[thread overview]
Message-ID: <E1PSkUR-0008Mm-3v@fencepost.gnu.org> (raw)
In-Reply-To: <AANLkTi=EMyuiERbXYuD=1fQf8ErxrFDGH7c_5Le9p_tz@mail.gmail.com>	(message from Doug Evans on Tue, 14 Dec 2010 17:40:10 -0800)

> X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED,
> 	T_DKIM_INVALID,T_RP_MATCHES_RCVD autolearn=ham version=3.3.1
> Date: Tue, 14 Dec 2010 17:40:10 -0800
> From: Doug Evans <dje@google.com>
> Cc: gdb-patches@sourceware.org
> 
> >> +Loads any auto-loaded scripts provided by the program being debugged.
> >> +@xref{Auto-loading}.
> >
> > In addition to the same rewording as above, this sounds inaccurate:
> > aren't these scripts loaded only as part of loading the debuggee's
> > executable file?  If so, we should mention that here, because (AFAIU),
> > invoking GDB without any program as the argument won't trigger any
> > auto-loading.
> 
> Reword per suggestion, but I kinda like the original wording.
> The context here is startup, e.g. shared libraries aren't read at this point.

"Startup" is not well defined, from the user's POV.  The manual uses
that term loosely as something vaguely understandable by everyone.
Wearing my user's hat, when I type "gdb core" or "gdb -p 1234",
everything GDB does before I get my first prompt is "startup".  That
includes loading shared libraries (unless auto-solib-add is OFF),
AFAIK.

> If you wish a different wording, can you provide one?  Thanks.

How about this one:

  If the command line specified a program to debug, or a process to
  attach to, or a core file, @value{GDBN} loads any auto-loaded
  scripts provided for the program or for its loaded shared libraries.
  @xref{Auto-Loading}.

> >> +@kindex set auto-load
> >> +@item set auto-load [yes|no]
> >> +Enable or disable the auto-loading of scripts.
> >> +
> >> +@kindex show auto-load
> >> +@item show auto-load
> >> +Show whether auto-loading is enabled or disabled.
> >>  @end table
> >
> > If we are going to leave this section inside the Python chapter, then
> > we should say "auto-load Python scripts" etc. elsewhere, because this
> > feature is limited to loading Python scripts, right?
> 
> I like what it's in the patch.
> There's no reason why one couldn't have non-python auto-loaded
> scripts, and there's no reason at the moment for having a different
> option to control them.
> So I don't want "python" in the option name.
> Having it the Python section of the manual is fine for now since
> that's all we currently support.

It's entirely unreasonable to have a command that is not limited to
Python in a Python specific section.  We could either move it out or
say something like "Enable or disable auto-loading of Python scripts."
(Note that I didn't ask to have "python" in the option's name.)
Please choose one or the other; I can go with either one.

I'm also open to other suggestions, if you (or someone else) have
them.

Thanks.


  reply	other threads:[~2010-12-15  6:05 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-11  0:47 Doug Evans
2010-12-11  8:16 ` Eli Zaretskii
2010-12-15  1:40   ` Doug Evans
2010-12-15  6:05     ` Eli Zaretskii [this message]
2010-12-15  6:26       ` Doug Evans
2010-12-15  6:58         ` Eli Zaretskii
2010-12-15  7:09           ` Doug Evans
2010-12-13 18:55 ` Jan Kratochvil
2010-12-13 19:28   ` Doug Evans
2010-12-13 19:36     ` Doug Evans

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1PSkUR-0008Mm-3v@fencepost.gnu.org \
    --to=eliz@gnu.org \
    --cc=dje@google.com \
    --cc=gdb-patches@sourceware.org \
    --cc=jan.kratochvil@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox