Re: [RFC] Let "gcore" command accept a suffix argument

Hui Zhu
2009-12-10T02:32:54Z

[-- Attachment #1: Type: text/plain, Size: 3497 bytes --]

Sorry I forgot post it to gdb-patches.

Hi guys,

I make a patch to make gdb support "eval gcore foo.$a" command.

(gdb) set $cmd="pwd"
(gdb) eval $cmd
Working directory /home/teawater/gdb/bgdbno/gdb.
(gdb) set $cmd="file ~/gdb/a.out"
(gdb) eval $cmd
Reading symbols from /home/teawater/gdb/a.out...done.
(gdb) start
Temporary breakpoint 1 at 0x80483be
Starting program: /home/teawater/gdb/a.out

Temporary breakpoint 1, 0x080483be in main ()
(gdb) set $name="eval"
(gdb) set $num=3
(gdb) eval gcore $name.$num
Saved corefile eval.3

Please post your comments about it.

And the help and file that include this command is not very well.
Please help me with them. :)

Thanks,
Hui

2009-12-10 Hui Zhu <teawater@gmail.com>
* printcmd.c (ctype.h): New include.
(eval_command): New function.
(_initialize_printcmd): New command "eval".

---
printcmd.c | 83 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 83 insertions(+)

--- a/printcmd.c
+++ b/printcmd.c
@@ -50,6 +50,8 @@
#include "parser-defs.h"
#include "charset.h"

+#include <ctype.h>
+
#ifdef TUI
#include "tui/tui.h" /* For tui_active et.al. */
#endif
@@ -2625,6 +2627,84 @@ printf_command (char *arg, int from_tty)
do_cleanups (old_cleanups);
}

+static void
+eval_command (char *exp, int from_tty)
+{
+#define CMDSIZE 1024
+ char cmd[CMDSIZE + 1];
+ char *cmdp = cmd;
+ int is_eval = 0;
+ char *eval_begin;
+
+ if (!exp)
+ return;
+
+ while (cmdp - cmd < CMDSIZE)
+ {
+ if (is_eval)
+ {
+ if (!isalnum (exp[0]) && exp[0] != '_')
+ {
+ struct value *value;
+ gdb_byte *buffer;
+ int length = -1;
+ struct type *char_type = NULL;
+ const char *la_encoding = NULL;
+ char tmp = exp[0];
+
+ exp[0] = '\0';
+ value = parse_and_eval (eval_begin);
+
+ switch (TYPE_CODE (value_type (value)))
+ {
+ case TYPE_CODE_ARRAY:
+ LA_GET_STRING (value, &buffer, &length,
+ &char_type, &la_encoding);
+ break;
+ case TYPE_CODE_INT:
+ buffer = plongest (value_as_long (value));
+ length = strlen (buffer);
+ break;
+ default:
+ buffer = eval_begin;
+ length = exp - eval_begin;
+ break;
+ }
+
+ if (length > CMDSIZE - (cmdp - cmd))
+ length = CMDSIZE - (cmdp - cmd);
+ memcpy (cmdp, buffer, length);
+ cmdp += length;
+
+ exp[0] = tmp;
+ is_eval = 0;
+ }
+ else
+ exp ++;
+ }
+ else
+ {
+ if (!exp[0])
+ break;
+
+ if (exp[0] == '$')
+ {
+ is_eval = 1;
+ eval_begin = exp;
+ }
+ else
+ {
+ cmdp[0] = exp[0];
+ cmdp ++;
+ }
+ exp ++;
+ }
+ }
+ cmdp[0] = '\0';
+
+ execute_command (cmd, from_tty);
+}
+
void
_initialize_printcmd (void)
{
@@ -2788,4 +2868,7 @@ Show printing of source filename and lin
NULL,
show_print_symbol_filename,
&setprintlist, &showprintlist);
+
+ add_com ("eval", no_class, eval_command, _("\
+Call command with variable."));
}

[-- Attachment #2: eval.txt --]
[-- Type: text/plain, Size: 2642 bytes --]

---
printcmd.c | 83 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 83 insertions(+)

--- a/printcmd.c
+++ b/printcmd.c
@@ -50,6 +50,8 @@
#include "parser-defs.h"
#include "charset.h"

+#include <ctype.h>
+
#ifdef TUI
#include "tui/tui.h" /* For tui_active et.al. */
#endif
@@ -2625,6 +2627,84 @@ printf_command (char *arg, int from_tty)
do_cleanups (old_cleanups);
}

+static void
+eval_command (char *exp, int from_tty)
+{
+#define CMDSIZE 1024
+ char cmd[CMDSIZE + 1];
+ char *cmdp = cmd;
+ int is_eval = 0;
+ char *eval_begin;
+
+ if (!exp)
+ return;
+
+ while (cmdp - cmd < CMDSIZE)
+ {
+ if (is_eval)
+ {
+ if (!isalnum (exp[0]) && exp[0] != '_')
+ {
+ struct value *value;
+ gdb_byte *buffer;
+ int length = -1;
+ struct type *char_type = NULL;
+ const char *la_encoding = NULL;
+ char tmp = exp[0];
+
+ exp[0] = '\0';
+ value = parse_and_eval (eval_begin);
+
+ switch (TYPE_CODE (value_type (value)))
+ {
+ case TYPE_CODE_ARRAY:
+ LA_GET_STRING (value, &buffer, &length,
+ &char_type, &la_encoding);
+ break;
+ case TYPE_CODE_INT:
+ buffer = plongest (value_as_long (value));
+ length = strlen (buffer);
+ break;
+ default:
+ buffer = eval_begin;
+ length = exp - eval_begin;
+ break;
+ }
+
+ if (length > CMDSIZE - (cmdp - cmd))
+ length = CMDSIZE - (cmdp - cmd);
+ memcpy (cmdp, buffer, length);
+ cmdp += length;
+
+ exp[0] = tmp;
+ is_eval = 0;
+ }
+ else
+ exp ++;
+ }
+ else
+ {
+ if (!exp[0])
+ break;
+
+ if (exp[0] == '$')
+ {
+ is_eval = 1;
+ eval_begin = exp;
+ }
+ else
+ {
+ cmdp[0] = exp[0];
+ cmdp ++;
+ }
+ exp ++;
+ }
+ }
+ cmdp[0] = '\0';
+
+ execute_command (cmd, from_tty);
+}
+
void
_initialize_printcmd (void)
{
@@ -2788,4 +2868,7 @@ Show printing of source filename and lin
NULL,
show_print_symbol_filename,
&setprintlist, &showprintlist);
+
+ add_com ("eval", no_class, eval_command, _("\
+Call command with variable."));
}