From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26196 invoked by alias); 6 Jan 2010 10:13:25 -0000 Received: (qmail 26186 invoked by uid 22791); 6 Jan 2010 10:13:24 -0000 X-SWARE-Spam-Status: No, hits=-1.1 required=5.0 tests=AWL,BAYES_05,SPF_PASS,WEIRD_QUOTING X-Spam-Check-By: sourceware.org Received: from fencepost.gnu.org (HELO fencepost.gnu.org) (140.186.70.10) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 06 Jan 2010 10:13:20 +0000 Received: from eliz by fencepost.gnu.org with local (Exim 4.69) (envelope-from ) id 1NSStB-0001gT-OG; Wed, 06 Jan 2010 05:13:17 -0500 From: Eli Zaretskii To: Hui Zhu CC: stanshebs@earthlink.net, tromey@redhat.com, stan@codesourcery.com, brobecker@adacore.com, msnyder@vmware.com, gdb-patches@sourceware.org In-reply-to: (message from Hui Zhu on Wed, 6 Jan 2010 14:57:32 +0800) Subject: Re: [RFC] Let "gcore" command accept a suffix argument Reply-to: Eli Zaretskii References: <4B29018C.6060307@codesourcery.com> <4B3BEDCC.9040103@earthlink.net> Message-Id: Date: Wed, 06 Jan 2010 10:13:00 -0000 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-01/txt/msg00108.txt.bz2 > From: Hui Zhu > Date: Wed, 6 Jan 2010 14:57:32 +0800 > Cc: gdb-patches ml > > I make a new patch that eval command use "" to point out the simple command. > If want add " in normal string. Use \" > If we want add \ in normal string. Use \\ > It can be use like: > (gdb) eval "echo \""$a++"\"" > "7"(gdb) eval "echo \""$a++"\"" > "8"(gdb) eval "echo \""$a++"\"" > "9"(gdb) eval "echo \""$a++"\"" > "10"(gdb) eval "echo \""$a++"\"" > "11"(gdb) eval "echo \""$a++"\"" > "12"(gdb) eval "echo \""$a++"\"" > "13"(gdb) eval "echo \""$a++"\"" > > Please help me review it. Thanks. This doc string: > + add_com ("eval", no_class, eval_command, _("\ > +Call command with variable.")); Should be much more detailed, and in particular say when quotes should be used and how to specify a literal quote character. It also needs an update for the manual. TIA