Re: patch for testing purposes

Joel Brobecker
2010-01-01T08:19:18Z

> Here it is again. For your information, I added a few lines of code
> to the 'info float' statement. Hope you like them :)

You are going to hate me, but it's still not right. Sorry!

How are you generating your diff? From the markers in the diff patch,
it looks like you generated it without the assistance of a version-control
system. You are making things harder for you because you have to make sure
that the tree that you use as a reference matches exactly what you started
from. Otherwise, you end up with differences that should not be in
the patch, as you are seeing at least in your patch to the ChangeLog file.

I strongly recommend that you start the safest way: Checkout the sources
from either CVS or git, apply your changes to these sources, and then
use either CVS or git to generate the diff (either "cvs diff -up" or
"git diff"). I would both sending a diff to the ChangeLog file but
simply put the ChangeLog entry in the email body. You can have a look
at previous messages sent to this mailing-list as a guideline. Please
verify that the patch you are sending corresponds exactly to the changes
you made, no more, no less.

Please also make sure to say that you did change your test by running
the testsuite before and after your change, comparing the results,
and on which platform. I can help walking you through this process
if you need help. But first, let's make sure you know how to generate
the patch properly, and that you know how to present them to this
mailing-list.

I hope you're not feeling discouraged. This is only a matter of learning
the procedure, and once you know it, you won't have to go through this
again, for most if not all GNU projects.

--
Joel