From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26232 invoked by alias); 20 Jun 2009 15:18:52 -0000 Received: (qmail 26223 invoked by uid 22791); 20 Jun 2009 15:18:52 -0000 X-SWARE-Spam-Status: No, hits=-2.2 required=5.0 tests=AWL,BAYES_00,J_CHICKENPOX_37,SPF_PASS X-Spam-Check-By: sourceware.org Received: from fencepost.gnu.org (HELO fencepost.gnu.org) (140.186.70.10) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 20 Jun 2009 15:18:44 +0000 Received: from eliz by fencepost.gnu.org with local (Exim 4.67) (envelope-from ) id 1MI2L4-0006C5-5u; Sat, 20 Jun 2009 11:18:42 -0400 From: Eli Zaretskii To: Chris Genly CC: gdb-patches@sourceware.org In-reply-to: (message from Chris Genly on Fri, 19 Jun 2009 21:11:07 -0700) Subject: Re: gdb.texinfo patch for -var-list-children (2) Reply-to: Eli Zaretskii References: Message-Id: Date: Sat, 20 Jun 2009 15:18:00 -0000 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-06/txt/msg00532.txt.bz2 > Date: Fri, 19 Jun 2009 21:11:07 -0700 > From: Chris Genly > > The gdb documentation for the MI command -var-list-children does not > define the exp > result for a child. Exp and other child results documented. Thanks. A few comments: > + @anchor{-var-info-num-children} Why did you add this @anchor? I don't see it referenced anywhere in your changes. > + For C/C++ structures there are several psuedo children returned to ^^^^^^ A typo. Also, please use "C@t{++}" instead of just "C++", the former looks better in print. Okay with these corrections. Btw, you seem to have no copyright assignment on file with the FSF, and your grace of 15 lines of contributions without an assignment is almost exhausted. Did you start your paperwork with FSF? If not, please consider doing that soon, or else we will be unable to accept your contributions. Thanks.