From: Eli Zaretskii <eliz@gnu.org>
To: "Ulrich Weigand" <uweigand@de.ibm.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [10/19] record_line
Date: Sat, 06 Jun 2009 01:15:00 -0000 [thread overview]
Message-ID: <E1MCkUt-0000zi-Ml@fencepost.gnu.org> (raw)
In-Reply-To: <200906052118.n55LIGmw029014@d12av02.megacenter.de.ibm.com> (uweigand@de.ibm.com)
> Date: Fri, 5 Jun 2009 23:18:16 +0200 (CEST)
> From: "Ulrich Weigand" <uweigand@de.ibm.com>
>
> the record_line routine calls gdbarch_addr_bits_remove on the PC it is
> passed. As there is no appropriate objfile at hand in this routine,
> the following patch moves this operation up into the callers of record_line,
> which will use the objfile architecture of the file they are processing.
Maybe I'm missing something, but isn't this rather inelegant? We are
moving some detail that is private to record_line into its callers,
just because record_line doesn't know the architecture nor the objfile
to get the architecture from? Why not simply pass the architecture or
the objfile to record_line instead?
next prev parent reply other threads:[~2009-06-06 1:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-05 21:18 Ulrich Weigand
2009-06-06 1:15 ` Eli Zaretskii [this message]
2009-06-08 14:53 ` Ulrich Weigand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1MCkUt-0000zi-Ml@fencepost.gnu.org \
--to=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=uweigand@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox