From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-57369-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 9904 invoked by alias); 19 Jul 2008 22:38:44 -0000
Received: (qmail 9895 invoked by uid 22791); 19 Jul 2008 22:38:43 -0000
X-Spam-Check-By: sourceware.org
Received: from fencepost.gnu.org (HELO fencepost.gnu.org) (140.186.70.10)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Sat, 19 Jul 2008 22:38:26 +0000
Received: from eliz by fencepost.gnu.org with local (Exim 4.67) 	(envelope-from <eliz@gnu.org>) 	id 1KKL3g-0005bZ-OB; Sat, 19 Jul 2008 18:37:44 -0400
From: Eli Zaretskii <eliz@gnu.org>
To: dje@google.com (Doug Evans)
CC: gdb-patches@sourceware.org
In-reply-to: <20080710203701.6AF041C769A@localhost> (dje@google.com)
Subject: Re: [RFA] set print symbol-loading on|off
Reply-to: Eli Zaretskii <eliz@gnu.org>
References:  <20080710203701.6AF041C769A@localhost>
Message-Id: <E1KKL3g-0005bZ-OB@fencepost.gnu.org>
Date: Sat, 19 Jul 2008 22:38:00 -0000
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2008-07/txt/msg00381.txt.bz2

> Date: Thu, 10 Jul 2008 13:37:01 -0700 (PDT)
> From: dje@google.com (Doug Evans)
> 
> Along the lines of "set print thread-events on|off",
> this option lets one turn off symbol loading messages.
> If the app has *lots* of shared libraries, these messages
> can be more noise than signal.

Thanks.

> --- NEWS	10 Jul 2008 16:44:47 -0000	1.280
> +++ NEWS	10 Jul 2008 20:16:31 -0000
> @@ -68,6 +68,10 @@ find [/size-char] [/max-count] start-add
>      val1 [, val2, ...]
>    Search memory for a sequence of bytes.
>  
> +set print symbol-loading
> +show print symbol-loading
> +  Control printing of symbol loading messages.

This is okay.

> -	  printf_unfiltered (_("Reading symbols from %s..."), name);
> -	  wrap_here ("");
> -	  gdb_flush (gdb_stdout);
> +          if (print_symbol_loading)
> +	    {
> +	      printf_unfiltered (_("Reading symbols from %s..."), name);
> +	      wrap_here ("");
> +	      gdb_flush (gdb_stdout);
> +	    }

I'm not sure doing this in complete silence is a good idea.  You've
shut up GDB, but this phase could take a long time, during which GDB
will appear to be hung.  How about printing a single message, like
"Reading symbols ..."?

> +  add_setshow_boolean_cmd ("symbol-loading", no_class,
> +                           &print_symbol_loading, _("\
> +Set printing of symbol loading messages."), _("\
> +Show printing of symbol loading messages."), NULL,

This is not enough detail.  As written, this doc string doesn't really
document anything in a useful manner.  Please add an explanation of
what this does, e.g. "When ON (the default), GDB will print messages
about loading symbols from shared libraries and debug info files."

> Index: doc/gdb.texinfo
> ===================================================================
> RCS file: /cvs/src/src/gdb/doc/gdb.texinfo,v

This part is okay.  Thanks.