Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Vladimir Prus <ghost@cs.msu.su>
To: Nick Roberts <nickrob@snap.net.nz>, gdb-patches@sources.redhat.com
Subject: Re: [PATCH: mi-cmd-file.c]
Date: Wed, 30 Jan 2008 07:19:00 -0000	[thread overview]
Message-ID: <E1JK79E-0004uN-5I@zigzag.lvk.cs.msu.su> (raw)
In-Reply-To: <18335.61046.331600.553026@kahikatea.snap.net.nz>

Nick Roberts wrote:

>  > > Actually Emacs turns tooltips off if there is no macro information in
>  > > case of something like:
>  > > 
>  > > #define STOP abort ()
>  > > 
>  > > and the mouse hovers over STOP.  Macro information allows Emacs to
>  > > ensure that a macro doesn't expand to a function first.
>  > 
>  > Hmm, that sounds silly.  If there's no macro information, GDB won't be
>  > able to expand STOP to a function...
> 
> Yes, what I've said is silly, but hopefully what I've done isn't.  When
> running in the old mode, as for Emacs 21, Emacs can't tell if the macro
> expands to a
> function, so turns off tooltips.  In the new mode, it checks to see if the
> macro expands to a function and if so, doesn't try to print its value
> (which would call abort () in this case).

I seems like this patch was checked in, and I see the following:

   FAIL: gdb.mi/mi-file.exp: request path info of current source file (basics.c)

and same for mi2-file.exp. Did you forgot to run testsuite, or forgot to
commit testsuite change?

- Volodya



  reply	other threads:[~2008-01-30  7:14 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-10  3:30 Nick Roberts
2008-01-29 18:08 ` Daniel Jacobowitz
2008-01-30  1:57   ` Nick Roberts
2008-01-30  3:06     ` Daniel Jacobowitz
2008-01-30  3:32       ` Nick Roberts
2008-01-30  7:19         ` Vladimir Prus [this message]
2008-01-30  9:30           ` Nick Roberts

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1JK79E-0004uN-5I@zigzag.lvk.cs.msu.su \
    --to=ghost@cs.msu.su \
    --cc=gdb-patches@sources.redhat.com \
    --cc=nickrob@snap.net.nz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox