From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21551 invoked by alias); 12 Feb 2007 06:18:27 -0000 Received: (qmail 21535 invoked by uid 22791); 12 Feb 2007 06:18:25 -0000 X-Spam-Check-By: sourceware.org Received: from zigzag.lvk.cs.msu.su (HELO zigzag.lvk.cs.msu.su) (158.250.17.23) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 12 Feb 2007 06:18:19 +0000 Received: from Debian-exim by zigzag.lvk.cs.msu.su with spam-scanned (Exim 4.50) id 1HGUVy-0005Xl-Rz for gdb-patches@sources.redhat.com; Mon, 12 Feb 2007 09:18:15 +0300 Received: from localhost ([127.0.0.1] helo=ip6-localhost) by zigzag.lvk.cs.msu.su with esmtp (Exim 4.50) id 1HGUVn-0005W3-Dh; Mon, 12 Feb 2007 09:18:03 +0300 From: Vladimir Prus Subject: Re: -var-create testsuite updates To: Nick Roberts , gdb-patches@sources.redhat.com Date: Mon, 12 Feb 2007 06:18:00 -0000 References: <20070209162019.GA14230@nevyn.them.org> <17871.36317.301688.678052@kahikatea.snap.net.nz> User-Agent: KNode/0.10.2 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7Bit Message-Id: Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-02/txt/msg00161.txt.bz2 Nick Roberts wrote: > > > (Groan) I picked up the tests which were designed to fail but changed > > > the > > > others by autopilot. I'll work my way through the changes to work > > > out how many others we should have kept and submit a new patch. > > > > Thanks a lot! I didn't want to actually ask you to do this, since it's > > a pile of grunt work, but it would certainly be nice to have them back. > > > > I only noticed because I had a few patches which changed long to > > long( int)? to support another compiler, and they no longer applied. > > Some tests are explicitly testing -var-create e.g mi-var-cmd.exp, others > might not be but still provide a handy check on the output e.g > > *** gdb.mi/mi-var-child.exp > > # Test: c_variable-4.2 > # Desc: create variable "struct_declarations" > mi_gdb_test "-var-create struct_declarations * struct_declarations" \ > "\\^done,name=\"struct_declarations\",numchild=\"11\",type=\"struct > _struct_decl\"" \ > "create local variable struct_declarations" > > I don't really like mi_create_varobj as it removes checks on type, number > of > children etc. This is intentional. Unless you're testing -var-create itself, you don't need to check every single output field from -var-create, because: 1. Tests for -var-create itself should test everything already, you don't get anything by extra tests. 2. Checking output of -var-create everywhere means any change in that output requires to update expected output, which is pointless. I think there should be "mi_var_create_varobj_test" that tests entire output. Tests for -var-create itself should use that. > How about if I revert all my changes which use > mi_create_varobj and just add value=\".*\" to the regexp in each > mi_gdb_test for -var-create? Why introducing new "mi_var_create_varobj_test" won't work? gdb testsuite has too much of literal expected output as it is. - Volodya