From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 603 invoked by alias); 4 Jan 2007 20:20:51 -0000 Received: (qmail 594 invoked by uid 22791); 4 Jan 2007 20:20:50 -0000 X-Spam-Check-By: sourceware.org Received: from zigzag.lvk.cs.msu.su (HELO zigzag.lvk.cs.msu.su) (158.250.17.23) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 04 Jan 2007 20:20:46 +0000 Received: from Debian-exim by zigzag.lvk.cs.msu.su with spam-scanned (Exim 4.50) id 1H2Z4t-00046d-0n for gdb-patches@sources.redhat.com; Thu, 04 Jan 2007 23:20:43 +0300 Received: from localhost ([127.0.0.1] helo=ip6-localhost) by zigzag.lvk.cs.msu.su with esmtp (Exim 4.50) id 1H2Z4k-00046N-JS; Thu, 04 Jan 2007 23:20:34 +0300 From: Vladimir Prus Subject: Re: [PATCH] MI: Add value field to output of -var-create To: Nick Roberts , gdb-patches@sources.redhat.com Date: Thu, 04 Jan 2007 20:20:00 -0000 References: <17818.12006.696879.216415@kahikatea.snap.net.nz> User-Agent: KNode/0.10.2 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7Bit Message-Id: Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-01/txt/msg00131.txt.bz2 Nick Roberts wrote: > > This patch just adds the value field to the output of var-create so that > the frontend doesn't need to issue another command to find out what it > is. > > If approved, I'll change the tests and documentation accordingly. I think this is a good change in general. However, the problem is that a lot of tests hardcode the output from -var-create, and are broken with this change. I think that instead of adding more hardcoding, we'd need to replace all creation of varobjs with calls to mi_create_varobj. Would you be willing to do that? - Volodya