Re: MI: Another -var-update bug? [PATCH]

Vladimir Prus
2007-01-04T18:51:07Z

Nick Roberts wrote:

> > > Good, that's not bad at all. If Vlad doesn't think this is likely to
> > > break kdevelop or Eclipse, the patch is OK.
> >
> > So, given that, why did you commit it? Maybe Vlad agreed with the
> > patch in another thread that I didn't read?
>
> He was part of the original thread and had posted messages subsequent to
> yours. I presumed that if he thought it would break anything he would have
> said so.

Had I immediately knew that this patch will break something, I'd say so.
But in practice, while I'm sure KDevelop won't care, I was not able to
make definite statement about Eclipse without looking at the code, and
I had no time for such look back then.

Given that this is already checked in, I'll let you know if I find any
problems with Eclipse.

- Volodya