Re: MI: Another -var-update bug? [PATCH]

Daniel Jacobowitz
2007-01-05T15:10:07Z

On Fri, Jan 05, 2007 at 12:10:09PM +0300, Vladimir Prus wrote:
> On Friday 05 January 2007 02:59, Nick Roberts wrote:
> > > This patch introduces this for me:
> > >
> > > FAIL: gdb.mi/mi-var-cp.exp: update RX (3)
> > >
> > > Do you get this failure to? If yes, can you please fix it?
> > > If no, let me know and I'll investigate.
> >
> > I don't get this failure.
>
> I suppose you've got some different version of gcc. I'll take a look.

I don't see the failure either.

> > Yes, it looks like the call to select_frame is not needed when the variable is
> > out of scope.
>
> Good. Do we have a rule in place that small fixes to one's most recent commit that
> seem obvious to you can be just committed? If yes, can you change this?

We don't have such a rule - but this would be an obvious change anyway,
in my opinion.

> > Daniel also suggested removing the call to reinit_frame_cache.
>
> I think that would be great as a separate patch.

Yes, I've been meaning to do it. Wasn't it part of a patch of mine you
reposted recently?

--
Daniel Jacobowitz
CodeSourcery