From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8855 invoked by alias); 4 Jan 2007 18:51:07 -0000 Received: (qmail 8845 invoked by uid 22791); 4 Jan 2007 18:51:06 -0000 X-Spam-Check-By: sourceware.org Received: from zigzag.lvk.cs.msu.su (HELO zigzag.lvk.cs.msu.su) (158.250.17.23) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 04 Jan 2007 18:51:02 +0000 Received: from Debian-exim by zigzag.lvk.cs.msu.su with spam-scanned (Exim 4.50) id 1H2Xfy-0007TG-GQ for gdb-patches@sources.redhat.com; Thu, 04 Jan 2007 21:50:59 +0300 Received: from localhost ([127.0.0.1] helo=ip6-localhost) by zigzag.lvk.cs.msu.su with esmtp (Exim 4.50) id 1H2Xfv-0007Mc-LM; Thu, 04 Jan 2007 21:50:51 +0300 From: Vladimir Prus Subject: Re: MI: Another -var-update bug? [PATCH] To: Nick Roberts , gdb-patches@sources.redhat.com Date: Thu, 04 Jan 2007 18:51:00 -0000 References: <17790.36044.454650.114329@kahikatea.snap.net.nz> <17817.34669.993434.397044@kahikatea.snap.net.nz> User-Agent: KNode/0.10.2 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7Bit Message-Id: Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-01/txt/msg00125.txt.bz2 Nick Roberts wrote: > > > Good, that's not bad at all. If Vlad doesn't think this is likely to > > > break kdevelop or Eclipse, the patch is OK. > > > > So, given that, why did you commit it? Maybe Vlad agreed with the > > patch in another thread that I didn't read? > > He was part of the original thread and had posted messages subsequent to > yours. I presumed that if he thought it would break anything he would have > said so. Had I immediately knew that this patch will break something, I'd say so. But in practice, while I'm sure KDevelop won't care, I was not able to make definite statement about Eclipse without looking at the code, and I had no time for such look back then. Given that this is already checked in, I'll let you know if I find any problems with Eclipse. - Volodya