From mboxrd@z Thu Jan 1 00:00:00 1970 From: RDBrown@mira.net To: gdb-patches@sources.redhat.com Subject: Patch: hpux warnings removal Date: Mon, 26 Mar 2001 14:40:00 -0000 Message-id: X-SW-Source: 2001-03/msg00473.html Building the 20010324 snapshot on hpux11, gdb still hangs starting the process. I think the 0320 snapshot also behaved this way on hpux10.20, built with either gcc-2.95.2 or the vendor compiler. The enclosed removes trigraph warnings etc. (for gdb/ChangeLog) 2001-03-26 Rodney Brown * config/pa/tm-hppa.h: Remove trigraph. * hp-symtab-read.c (hpread_type_translate): Provide return value. (hpread_read_struct_type): Remove trigraph. Add parameter in `warning'. (hpread_read_array_type): Provide return value. (hpread_type_lookup): Avoid ambiguous `else'. Provide return value. * hppa-tdep.c (initialize_hp_cxx_exception_support): Remove trigraph. (for include/elf/ChangeLog) 2001-03-26 Rodney Brown * mips.h: Remove trigraphs. --- gdb/config/pa/tm-hppa.h.orig Thu Mar 15 09:23:14 2001 +++ gdb/config/pa/tm-hppa.h Mon Mar 26 23:07:13 2001 @@ -568,7 +568,7 @@ extern void hppa_pop_frame (void); #else /* defined PA_LEVEL_0 */ /* This is the call dummy for a level 0 PA. Level 0's don't have space - registers (or floating point??), so we skip all that inter-space call stuff, + registers (or floating point?), so we skip all that inter-space call stuff, and avoid touching the fp regs. call_dummy --- gdb/hp-symtab-read.c.orig Tue Mar 6 18:21:08 2001 +++ gdb/hp-symtab-read.c Mon Mar 26 23:14:35 2001 @@ -530,7 +530,7 @@ hpread_type_translate (dnttpointer typep if (!typep.dntti.immediate) { error ("error in hpread_type_translate\n."); - return; + return FT_VOID; } switch (typep.dntti.type) @@ -1780,7 +1780,7 @@ hpread_read_struct_type (dnttpointer hp_ /* Enums -- will be handled by other code that takes care of DNTT_TYPE_ENUM; here we see only DNTT_TYPE_MEMENUM so it's not clear we could have handled them here at all. */ - /* FUNC_TEMPLATE: is handled by other code (??). */ + /* FUNC_TEMPLATE: is handled by other code (?). */ /* MEMACCESS: modified access for inherited member. Not sure what to do with this, ignoriing it at present. */ @@ -1863,7 +1863,8 @@ hpread_read_struct_type (dnttpointer hp_ { /* neither field nor genfield ?? is this possible?? */ /* pai:: FIXME walk to the next -- how? */ - warning ("Internal error: unexpected DNTT kind %d encountered as field of struct"); + warning ("Internal error: unexpected DNTT kind %d encountered as field of struct", + fieldp->dblock.kind); warning ("Skipping remaining fields of struct"); break; /* get out of loop of fields */ } @@ -2199,7 +2200,7 @@ hpread_read_array_type (dnttpointer hp_t (!dn_bufp->darray.arrayisbytes && !dn_bufp->darray.elemisbytes))) { warning ("error in hpread_array_type.\n"); - return; + return NULL; } else if (dn_bufp->darray.arraylength == 0x7fffffff) { @@ -2302,14 +2303,17 @@ hpread_type_lookup (dnttpointer hp_type, /* First see if it's a simple builtin type. */ if (hp_type.dntti.immediate) - /* If this is a template argument, the argument number is - * encoded in the bitlength. All other cases, just return - * GDB's representation of this fundamental type. - */ - if (hp_type.dntti.type == HP_TYPE_TEMPLATE_ARG) - return hpread_get_nth_template_arg (objfile, hp_type.dntti.bitlength); - else - return lookup_fundamental_type (objfile, hpread_type_translate (hp_type)); + { + /* If this is a template argument, the argument number is + * encoded in the bitlength. All other cases, just return + * GDB's representation of this fundamental type. + */ + if (hp_type.dntti.type == HP_TYPE_TEMPLATE_ARG) + return hpread_get_nth_template_arg (objfile, hp_type.dntti.bitlength); + else + return lookup_fundamental_type (objfile, + hpread_type_translate (hp_type)); + } /* Not a builtin type. We'll have to read it in. */ if (hp_type.dnttp.index < LNTT_SYMCOUNT (objfile)) @@ -2425,7 +2429,7 @@ hpread_type_lookup (dnttpointer hp_type, else { complain (&hpread_type_lookup_complaint); - return; + return NULL; } if (dn_bufp->dblock.kind == DNTT_TYPE_STRUCT) --- gdb/hppa-tdep.c.orig Mon Mar 26 23:17:26 2001 +++ gdb/hppa-tdep.c Mon Mar 26 23:12:58 2001 @@ -4250,7 +4250,7 @@ initialize_hp_cxx_exception_support (voi if (!eh_notify_callback_addr) { /* We can get here either if there is no plabel in the export list - for the main image, or if something strange happened (??) */ + for the main image, or if something strange happened (?) */ warning ("Couldn't find a plabel (indirect function label) for the exception callback."); warning ("GDB will not be able to intercept exception events."); return 0; --- include/elf/mips.h.orig Mon Mar 26 23:26:29 2001 +++ include/elf/mips.h Mon Mar 26 23:08:53 2001 @@ -469,7 +469,7 @@ extern void bfd_mips_elf32_swap_reginfo_ /* Runtime procedure table. */ #define PT_MIPS_RTPROC 0x70000001 -/* Options (for what ???). */ +/* Options (for what?). */ #define PT_MIPS_OPTIONS 0x70000002 /* Processor specific dynamic array tags. */ @@ -558,7 +558,7 @@ extern void bfd_mips_elf32_swap_reginfo_ /* Flags indicating information about C++ flavor. */ #define DT_MIPS_CXX_FLAGS 0x70000022 -/* Pixie information (???). */ +/* Pixie information ( ? ). */ #define DT_MIPS_PIXIE_INIT 0x70000023 /* ??? */