From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 103983 invoked by alias); 6 Mar 2018 09:34:20 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 99111 invoked by uid 89); 6 Mar 2018 09:34:15 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.0 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: EUR01-DB5-obe.outbound.protection.outlook.com Received: from mail-db5eur01on0058.outbound.protection.outlook.com (HELO EUR01-DB5-obe.outbound.protection.outlook.com) (104.47.2.58) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 06 Mar 2018 09:34:04 +0000 Received: from AM3PR08MB0101.eurprd08.prod.outlook.com (10.160.211.19) by AM3PR08MB0008.eurprd08.prod.outlook.com (10.160.236.142) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.548.13; Tue, 6 Mar 2018 09:34:00 +0000 Received: from AM3PR08MB0101.eurprd08.prod.outlook.com ([fe80::fc60:4b4d:7de8:f8b7]) by AM3PR08MB0101.eurprd08.prod.outlook.com ([fe80::fc60:4b4d:7de8:f8b7%16]) with mapi id 15.20.0548.016; Tue, 6 Mar 2018 09:34:00 +0000 From: Alan Hayward To: "Metzger, Markus T" CC: "gdb-patches@sourceware.org" , nd Subject: Re: [PATCH v2 1/2] btrace: fix output of "set record btrace" Date: Tue, 06 Mar 2018 09:34:00 -0000 Message-ID: References: <1520247555-4643-1-git-send-email-markus.t.metzger@intel.com> <6BDA00D9-3EA2-4BCC-AA97-42547CFA808F@arm.com> In-Reply-To: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alan.Hayward@arm.com; x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;AM3PR08MB0008;7:akvdKZcI93juZhOD0A3S1n6UYnIqpgOhlr18O1WXuLGk+Belo8Z412dwTAZiuFQozwWM6+UMLntne3KQmNbyV8EBE1tvL96ksIP8BA7BsvV1hxLlfkGfWcFOMc7MrirHuGnASm3fvyAc9d5++gCQkGHoDnEnpbCUSE9KpBXYQKFEKFLaO/R1n4KxLCLamB2j0fxDNF8J3VGMihs4KqZLIEUbgN4Hi/1nInFl/LYjmUCzxV3QGC++KUFbf6SSN3RP x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 5d910a85-59dd-4c4d-b24f-08d583456475 x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(7020095)(4652020)(48565401081)(5600026)(4604075)(3008032)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020);SRVR:AM3PR08MB0008; x-ms-traffictypediagnostic: AM3PR08MB0008: nodisclaimer: True x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(228905959029699); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(8211001083)(6040501)(2401047)(5005006)(8121501046)(3002001)(3231220)(944501244)(52105095)(93006095)(93001095)(10201501046)(6055026)(6041288)(20161123564045)(20161123560045)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(6072148)(201708071742011);SRVR:AM3PR08MB0008;BCL:0;PCL:0;RULEID:;SRVR:AM3PR08MB0008; x-forefront-prvs: 06036BD506 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(396003)(346002)(376002)(366004)(39860400002)(39380400002)(377424004)(189003)(199004)(186003)(2900100001)(82746002)(478600001)(76176011)(33656002)(72206003)(105586002)(5660300001)(316002)(6506007)(26005)(59450400001)(36756003)(5250100002)(15974865002)(102836004)(99286004)(4326008)(86362001)(575784001)(83716003)(14454004)(53546011)(54906003)(81156014)(3280700002)(8676002)(8936002)(81166006)(66066001)(6116002)(3846002)(2906002)(53936002)(25786009)(2950100002)(6486002)(6916009)(6436002)(6512007)(68736007)(106356001)(3660700001)(7736002)(97736004)(305945005)(229853002)(6246003);DIR:OUT;SFP:1101;SCL:1;SRVR:AM3PR08MB0008;H:AM3PR08MB0101.eurprd08.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: Ky9vDRqCnNrAqnkh/MV8oH3+xyBdEUyPO4g+fJ5rZP+cue6YkDVW2YtgO9wcEzYw3+rTuO5+rtWdBAmB1GAnZod9gQ7bCD3KeII0sRzZhw7yry7BgsgOFE9CglMMBipD4Ihzx/ORVgEOdkjgVhnjK1s6hm/XOFAnX45ov4sVBCbLNqp7Adi9FPHtm9dnre1DaZMjAa9/xcfu19eAjExIhhM0bD8wBO98jm9l1PFA+IxpVqByQlXwL/8X5hPDw6sKdIcrd+Wewp+uKp5EFPe9M92staaXAnfE4NrzIXEnLDr53wXgrY1lvEfUWkK3lUNSl6qKBH6UAHUtKeXdKH1Sew== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-ID: <9BA8231A0B5AD94D997632B4DC1A0B1F@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5d910a85-59dd-4c4d-b24f-08d583456475 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Mar 2018 09:34:00.2491 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM3PR08MB0008 X-IsSubscribed: yes X-SW-Source: 2018-03/txt/msg00132.txt.bz2 > On 5 Mar 2018, at 16:55, Metzger, Markus T w= rote: >=20 > Hello Alan, >=20 > Thanks for your review. >=20 >>> Instead of giving a message that "set record btrace" needs a >>> sub-command, GDB crashed. Fix it. A regression test comes with the ne= xt >> patch. >>>=20 >>> 2018-03-05 Markus Metzger >>>=20 >>> gdb/ >>> * record-btrace.c (cmd_set_record_btrace): Print sub-commands. >>> --- >>> gdb/record-btrace.c | 5 ++++- >>> 1 file changed, 4 insertions(+), 1 deletion(-) >>>=20 >>> diff --git a/gdb/record-btrace.c b/gdb/record-btrace.c index >>> 48eda54..905f0c4 100644 >>> --- a/gdb/record-btrace.c >>> +++ b/gdb/record-btrace.c >>> @@ -2953,7 +2953,10 @@ cmd_record_btrace_start (const char *args, int >>> from_tty) static void cmd_set_record_btrace (const char *args, int >>> from_tty) { >>> - cmd_show_list (set_record_btrace_cmdlist, from_tty, ""); >>> + printf_unfiltered (_("\"set record btrace\" must be followed " >>> + "by an apporpriate subcommand.\n")); >>=20 >> appropriate not apporpriate. >=20 > Thanks. I'm adding another patch to the series to fix that same typo in = the > "set record" command from where I took the message. See below. >=20 > Looks like this text is not used in any test (grep did not find anything), > except for the new gdb.btrace/cpu.exp that 2/2 of this series adds. >=20 New patch LGTM. > Regards, > Markus. >=20 > --- >=20 > commit 755376c12a2fa53d8304ff68265a09b8a332e965 > Author: Markus Metzger > Date: Mon Mar 5 17:44:57 2018 +0100 >=20 > record: fix typo in "set record" output >=20 > Alan Hayward pointed out a typo in the output of "set record btrace" t= hat > I took from "set record". Fix the original. >=20 > Signed-off-by: Markus Metzger >=20 > gdb/ > * record.c (set_record_command): Fix typo in message. >=20 > diff --git a/gdb/record.c b/gdb/record.c > index cd83b99..aec2be3 100644 > --- a/gdb/record.c > +++ b/gdb/record.c > @@ -320,7 +320,7 @@ static void > set_record_command (const char *args, int from_tty) > { > printf_unfiltered (_("\"set record\" must be followed " > - "by an apporpriate subcommand.\n")); > + "by an appropriate subcommand.\n")); > help_list (set_record_cmdlist, "set record ", all_commands, gdb_stdout); > } >=20 > Intel Deutschland GmbH > Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany > Tel: +49 89 99 8853-0, www.intel.de > Managing Directors: Christin Eisenschmid, Christian Lamprechter > Chairperson of the Supervisory Board: Nicole Lau > Registered Office: Munich > Commercial Register: Amtsgericht Muenchen HRB 186928 >=20