Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Aditya Kamath <Aditya.Kamath1@ibm.com>
To: Simon Marchi <simon.marchi@polymtl.ca>,
	Aditya Vidyadhar Kamath <akamath996@gmail.com>,
	Ulrich Weigand <Ulrich.Weigand@de.ibm.com>,
	"tom@tromey.com" <tom@tromey.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
	SANGAMESH MALLAYYA <sangamesh.swamy@in.ibm.com>
Subject: RE: [PATCH v5] Fix styles in aix-thread.c to follow GNU style code.
Date: Tue, 6 Oct 2026 11:13:49 +0000	[thread overview]
Message-ID: <DSWPR15MB31981740E2EC171F73939E3C84D6952@DSWPR15MB319817.namprd15.prod.outlook.com> (raw)
In-Reply-To: <e7570ec5-7052-40e2-b7b2-218bad18114b@polymtl.ca>

[-- Attachment #1: Type: text/plain, Size: 606 bytes --]


Hi Simon,

>Thanks, I have a few comments below, but otherwise this LGTM.  You can
>push with those fixed.  Just make sure that you only have whitespace
>changes.
>Approved-By: Simon Marchi <simon.marchi@efficios.com>

Thanks. I have pushed the same.

https://sourceware.org/git/?p=binutils-gdb.git;a=commitdiff;h=e838ff7efdee2779adec99567e88b59ab0e5d4d2

Yes, changes are whitespace only and no functional changes. Also, there were 4 other similar changes where your suggestions applied and clang-format binary suggested. Did that as well.

Have a nice day ahead.

Regards,
Aditya.



[-- Attachment #2: Type: text/html, Size: 2480 bytes --]

      reply	other threads:[~2026-10-06 11:14 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-05 18:55 Aditya Vidyadhar Kamath
2026-10-05 20:04 ` Simon Marchi
2026-10-06 11:13   ` Aditya Kamath [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DSWPR15MB31981740E2EC171F73939E3C84D6952@DSWPR15MB319817.namprd15.prod.outlook.com \
    --to=aditya.kamath1@ibm.com \
    --cc=Ulrich.Weigand@de.ibm.com \
    --cc=akamath996@gmail.com \
    --cc=gdb-patches@sourceware.org \
    --cc=sangamesh.swamy@in.ibm.com \
    --cc=simon.marchi@polymtl.ca \
    --cc=tom@tromey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox