RE: [PATCH 1/1] testsuite: skip confirmation in 'gdb_reinitialize_dir'

["Rohr, Stephan" <stephan.rohr@intel.com>]

Hi Eli,

I further investigated the issue.  The issue is triggered if "TERM=dump" is set in a MinGW
environment.  I can reproduce the issue in CLI mode, too:

  $ ./gdb -q
  (gdb) dir
  Reinitialize source path to empty? (y or n) [answered Y; input not from terminal]
  Source directories searched: $cdir;$cwd
  (gdb)

I used the setting to workaround some issues when running tests on Windows using
MinGW.  I can see that control characters are added to the output of different commands,
e.g., 'test_compiler_info' fails with:

  builtin_spawn -ignore SIGHUP gcc -fdiagnostics-color=never -c -o ...
  ^[[6nget_compiler_info: gcc-14-2-0
  get_compiler_info: gcc-14-2-0
  Executing on host: gcc  -fno-stack-protector  -w -c -g  -o ...
  builtin_spawn -ignore SIGHUP gcc -fno-stack-protector -w -c -g -o ...
  ^[[6noutput is:
  ^[[6n
  gdb compile failed, ^[[6n

I haven't understood yet why this is added in MinGW or how to disable those.

The patch enables me to run the tests I'm interested in in a MinGW environment.

Thanks
Stephan

> -----Original Message-----
> From: Eli Zaretskii <eliz@gnu.org>
> Sent: Thursday, 14 November 2024 10:44
> To: Rohr, Stephan <stephan.rohr@intel.com>
> Cc: gdb-patches@sourceware.org
> Subject: Re: [PATCH 1/1] testsuite: skip confirmation in 'gdb_reinitialize_dir'
> 
> > From: Stephan Rohr <stephan.rohr@intel.com>
> > Date: Thu, 14 Nov 2024 01:00:51 -0800
> >
> > From: "Rohr, Stephan" <stephan.rohr@intel.com>
> >
> > Some shells automatically confirm the 'dir' command:
> >
> >   (gdb) dir
> >   Reinitialize source path to empty? (y or n)
> >     [answered Y; input not from terminal]
> >   Source directories searched: $cdir;$cwd
> >   (gdb) y
> >   dir <...>/gdb/testsuite/gdb.base
> >   Undefined command: "y".  Try "help".
> 
> Which shell is involved here?
> 
> > For example, this reprdocues on a MinGW32 environment.  Skip sending
> > 'y' if the command is already confirmed.
> > ---
> >  gdb/testsuite/lib/gdb.exp | 6 ++++--
> >  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> Are you saying this problem happens only in the test suite?  When I
> run GDB interactively, typing "dir" followed by Enter does request my
> confirmation, it doesn't confirm automatically.  Why does that happen
> in the test suite?
> 
> Thanks.
Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de
Managing Directors: Sean Fennelly, Jeffrey Schneiderman, Tiffany Doon Silva
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928