Re: [PATCH v2 07/47] gdb, gdbserver, gdbsupport: add 'device' tag to XML target description

Eli Zaretskii
2024-12-13T16:45:44Z

> From: Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
> Date: Fri, 13 Dec 2024 16:59:24 +0100
>
> gdb/NEWS | 8 ++++
> gdb/doc/gdb.texinfo | 25 +++++++++++++
> gdb/features/gdb-target.dtd | 19 +++++++++-
> gdb/target-descriptions.c | 19 ++++++++++
> gdb/xml-tdesc.c | 76 ++++++++++++++++++++++++++++++++++++++
> gdbserver/tdesc.cc | 16 ++++++++
> gdbserver/tdesc.h | 3 ++
> gdbsupport/tdesc.cc | 40 ++++++++++++++++++++
> gdbsupport/tdesc.h | 90 +++++++++++++++++++++++++++++++++++++++++++++
> 9 files changed, 295 insertions(+), 1 deletion(-)

Thanks.

> --- a/gdb/NEWS
> +++ b/gdb/NEWS
> @@ -174,6 +174,14 @@ vFile:stat
> vFile:fstat but takes a filename rather than an open file
> descriptor.
>
> +* Changed remote packets
> +
> +qXfer:features:read:target.xml
> +
> + The XML that is sent as a response can now include a "device" element
> + that can be used for passing information when the remote inferior
> + represents a device, e.g. a GPU.
^^^
Extra whitespace.

> --- a/gdb/doc/gdb.texinfo
> +++ b/gdb/doc/gdb.texinfo

This part is okay.

Reviewed-By: Eli Zaretskii <eliz@gnu.org>