Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "Metzger, Markus T via Gdb-patches" <gdb-patches@sourceware.org>
To: Tom de Vries <tdevries@suse.de>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: RE: [PATCH][gdb/testsuite] Fix gdb.btrace/tsx.exp on system with tsx disabled in microcode
Date: Mon, 12 Jul 2021 14:35:59 +0000	[thread overview]
Message-ID: <DM8PR11MB5749D760A23A6FDC8B0A5A64DE159@DM8PR11MB5749.namprd11.prod.outlook.com> (raw)
In-Reply-To: <0e162414-67d4-a05c-6603-c4521b480e1c@suse.de>

Hello Tom,

> diff --git a/gdb/testsuite/gdb.btrace/tsx.exp b/gdb/testsuite/gdb.btrace/tsx.exp
> index ccde1ea807e..66f6305e50a 100644
> --- a/gdb/testsuite/gdb.btrace/tsx.exp
> +++ b/gdb/testsuite/gdb.btrace/tsx.exp
> @@ -59,6 +59,11 @@ set abort_2 [multi_line \
>      "\[0-9\]*\t   0x\[0-9a-f\]+ <test\\+\[0-9\]+>:\tmov\[^\\\r\\\n\]*" \
>      "\[0-9\]*\t   0x\[0-9a-f\]+ <test\\+\[0-9\]+>:\tret\[^\\\r\\\n\]*" \
>      ]
> +set abort_3 \
> +    [multi_line \
> +	 "$decimal\t   $hex <main\\+$decimal>:\t\[^\\\r\\\n\]*" \
> +	 "$decimal\t   $hex <test\\+$decimal>:\tmov\[^\\\r\\\n\]*" \
> +	 "$decimal\t   $hex <test\\+$decimal>:\tret\[^\\\r\\\n\]*"]
>  
>  set test "speculation indication"
>  gdb_test_multiple "record instruction-history" $test {
> @@ -68,6 +73,9 @@ gdb_test_multiple "record instruction-history" $test {
>      -re "$abort_2.*$gdb_prompt $" {
>          pass $test
>      }
> +    -re -wrap "$abort_3.*" {
> +        pass $gdb_test_name
> +    }
>      -re  "$begin_to_end.*$gdb_prompt $" {
>          pass $test
>      }

We allow (and require) a single instruction in main.  That works if we stopped
directly at the call.  I don't think we can guarantee that.

In the other patterns, I put .* in front to ignore any compiler-generated
code prior to the actual test.

Regards,
Markus.
Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva  
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928

  reply	other threads:[~2021-07-12 14:37 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-12 11:27 Tom de Vries
2021-07-12 11:54 ` Metzger, Markus T via Gdb-patches
2021-07-12 14:05   ` Tom de Vries
2021-07-12 14:35     ` Metzger, Markus T via Gdb-patches [this message]
2021-07-12 15:08       ` Tom de Vries
2021-07-12 15:19         ` Metzger, Markus T via Gdb-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DM8PR11MB5749D760A23A6FDC8B0A5A64DE159@DM8PR11MB5749.namprd11.prod.outlook.com \
    --to=gdb-patches@sourceware.org \
    --cc=markus.t.metzger@intel.com \
    --cc=tdevries@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox