From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id WlOlCacrZmI0ZQIAWB0awg (envelope-from ) for ; Mon, 25 Apr 2022 01:03:35 -0400 Received: by simark.ca (Postfix, from userid 112) id 1AAF61E058; Mon, 25 Apr 2022 01:03:35 -0400 (EDT) Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=mw4jKzSO; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 0C54E1E00D for ; Mon, 25 Apr 2022 01:03:34 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 162A43858D33 for ; Mon, 25 Apr 2022 05:03:33 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 162A43858D33 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1650863013; bh=krBT6oy2Fa1QxMxxHQ/rMF+mNcnjNrI/28AKlS+nl8Y=; h=To:Subject:Date:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=mw4jKzSOy8qwa56Q4lQlxCqZAMZt1Kgrpbz8vlRraUYmpn3O8jl+L2hRnTsuUWEgc KHAxi0fGbDiWgGiK/JmliDO22XlELuA7HCmMxy7eGjga+AsHRP/O2YjNNDRautWV1p g4XWCp8iZE00cdXy+S04npgz3P0n6kik5gP1c3qQ= Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by sourceware.org (Postfix) with ESMTPS id B472E3858D33 for ; Mon, 25 Apr 2022 05:03:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B472E3858D33 X-IronPort-AV: E=McAfee;i="6400,9594,10327"; a="263988229" X-IronPort-AV: E=Sophos;i="5.90,287,1643702400"; d="scan'208";a="263988229" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Apr 2022 22:03:10 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,287,1643702400"; d="scan'208";a="563932683" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by fmsmga007.fm.intel.com with ESMTP; 24 Apr 2022 22:03:10 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Sun, 24 Apr 2022 22:03:09 -0700 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Sun, 24 Apr 2022 22:03:09 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Sun, 24 Apr 2022 22:03:09 -0700 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (104.47.74.44) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Sun, 24 Apr 2022 22:03:09 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kDs45cXpqZ1KlD9ATIp5Tos+9fYHEKkZaKmkKG5lGOhloXvaGH9oT/r6ZbgoCOp1J7iEDShr0Y4U+k7xsS0NvbzczjY7KoTWZVYzH80akRODJYmehI8OZi9PzXVxGR3ahtZtw3yPd/IJ96qn5V12KOT2khIyVzGfSWVPYvqToM4+JGf6F0SfwPyoNeEg+oZAVmAq86XKDg/3EIG5gxstU4BTSVJtBJVpT6T93CRfqdtcrEQrk4jLffFO+ayj0lqW+cHyqur8GUksK/fTLbwPzFg/iF+3WK44gM529oymIxSXZojVbkNf2xToRBXK3NgG8gnwBvbBDV1VMfUAktl1hg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MYM5rdLsr2Zkq7+5FNOXS+OX2C1rz+4pPhTONVdVBPU=; b=fRa7PEVwxwT/jQSEkMoKEN3x/iTI0AH5eqN+uZxa0ifgVQFpRuiCtthH7mSQTGvm8UvrlRyTy+BryRIAGZdWPYW09Z2HZoaCTBFj8tglrARSQ2wG3zwaxOIOFcb2G/+sDrd4H7MqsIkIWfZd6f5CyaMgdGO0mhEIhjNs5134gu/uWRbuHtq6KOzGC38MxPeALFW4V7SgybKwsni2Nd499NhN99JgdE9b0iycsI1B6q/SFMJn1ZdkZ1nEFHBqRoZZ15mrZh18l8tCgumue2QAAeZlR/aZ46Y698XpaPSl0zA3gf+oyxwIIocLBdngWQewnmKp63pmV4sWAcD3mbwkPA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM8PR11MB5749.namprd11.prod.outlook.com (2603:10b6:8:10::15) by MW3PR11MB4682.namprd11.prod.outlook.com (2603:10b6:303:2e::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.14; Mon, 25 Apr 2022 05:03:07 +0000 Received: from DM8PR11MB5749.namprd11.prod.outlook.com ([fe80::18aa:3ac7:75c0:e704]) by DM8PR11MB5749.namprd11.prod.outlook.com ([fe80::18aa:3ac7:75c0:e704%6]) with mapi id 15.20.5186.021; Mon, 25 Apr 2022 05:03:07 +0000 To: Zied Guermazi Subject: RE: [PATCH 1/1] get page size using sysconf (_SC_PAGESIZE) instead of PAGE_SIZE Thread-Topic: [PATCH 1/1] get page size using sysconf (_SC_PAGESIZE) instead of PAGE_SIZE Thread-Index: AQHYWCCWAVTph21znU69DEpQjTmPKa0AD+Pw Date: Mon, 25 Apr 2022 05:03:07 +0000 Message-ID: References: <20220424211541.70674-1-zied.guermazi@trande.de> <20220424211541.70674-2-zied.guermazi@trande.de> In-Reply-To: <20220424211541.70674-2-zied.guermazi@trande.de> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.401.20 dlp-product: dlpe-windows x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 8975b58c-5acb-460c-5ee0-08da2678e2ef x-ms-traffictypediagnostic: MW3PR11MB4682:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Wuj01CCfUNNgoTx2FTCJoyp46CyVX7WJlpTdSaDTENKVeGTqyNx5Sp9iaVtTJrS82lAexxkzJFvH1IsyYtdeeyVjenhaGI9RUCYvxYSIoL9L4a7EA8LTrjvswwGDx5UcZTyidEhmPEMLeoylI8sPeqLLm38QzOdulOEjP7lHPD5pCxW1Q+i7kU13imiKL8Zraov+mnsUTb7FHRdMSSYhBLXTtllBcwCLus5FaCgD1aVfv9hAd+Zd96e2J2nmt3b54p9F8zqKfY+/jA84FFaVmolRYQNGcNzLQXHsMrqFv2Kes2i2M+ppzUHEbFAP4Uq3skXquJJpk5U9891BTjNG42viio5CpBD02aLhhE9wYIWbmevrk7Ps8SO6iHPG7IdoOptKB3Dj+5gs/qF/3OFmAsp9nuAEQLTqMkDTR7ewvuV3aNOYTYtI9gYXDEhvleLx+NFxQIZry0XlSs1Tcb2EdHQaDmc3b9mF+Dgo81xcAnri4Ygoc/qZonax6Qj3CzX/HvXvFIzfh0iGf7UncjRW7qDnerXiALouHO9wCoRW43nSRKUOPDXj89+aY5XDlnFH6BuJWrePtTvy+iwEN1/LGn8rqfBDc9MY43CiIlIu1WVw3Y9aunK2DHBto+KcTN14SnQ2vOHC4U/km5hmFRegqELA5aetgzr54FcZYoyRT8VGd5H0w/vpARi8tmXjjiNs+GsaRVXZjz94kIBeffXpHQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM8PR11MB5749.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(5660300002)(52536014)(8936002)(9686003)(55016003)(83380400001)(122000001)(33656002)(186003)(6506007)(86362001)(26005)(38100700002)(38070700005)(82960400001)(71200400001)(7696005)(8676002)(508600001)(64756008)(2906002)(66556008)(4326008)(66446008)(76116006)(66946007)(66476007)(316002)(6916009); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?aUvXc0aSohpaBxeG5oHgGV4wQJoH9LGn5gn0tvG+8FJEGQI7D6XCezT7Usfh?= =?us-ascii?Q?lxv5RiEUI0KGrKhhH+H+ziv+QlOkFqO/H6R4M0qWXSh/gFAHTbGCtLQDagbH?= =?us-ascii?Q?NOoed48hZAHWrKlDcH098yM5dS/3/jkn4Wxl2Pj5WMvUg369OnJmbDABz3en?= =?us-ascii?Q?NsAtdXb/DQNtRzhEt5mUGE1RuTQCGFrAUmHcP9GmXM4SHKcxstiN3hZEVHpd?= =?us-ascii?Q?JdBpu7zvjL6lURRy0epTFfGa3ME8gD+uKdVP6jbr7YeID8Ddgv/b8YhVCXHS?= =?us-ascii?Q?OnFFAHjtx+xmIAkMfbqjrul62qXsyyZEN+q3Rf5BmLVqbbmT7x1inJhnivC9?= =?us-ascii?Q?FOxgPNS3e4WxIRW7oLBhfxe+ZvfLOynfF72yjwe8LkAIJmLpi4GnILUvjtHH?= =?us-ascii?Q?LHxJjk5rjNXoaA42dJw6YaEGFMq4VLikXwsotUmmzjN05rWS2/8e2FY+rl9t?= =?us-ascii?Q?+qCQJaQzpFWo1yZeU6AKDe0orSVJSJTNyBK5Qu4wD6gWdF+eX1QPjKhdCBcm?= =?us-ascii?Q?QHXwB1qM+NS/Jl33ki2tEav46JKJfB0YjY5EeAO7DMUDRyandyhJ+owT6bpo?= =?us-ascii?Q?sP7542IfeE7o+R1r3ltgpX2FaTyhKOutVD6RGOrmFx8b9OU9qHoeXP41aYOF?= =?us-ascii?Q?El9PlEg43O/pZ2oAiChYbbUDj+zNDKXvL56+zDT5ctMsTGKNZ6lEMiFGc+wp?= =?us-ascii?Q?4vELzv1OrXD72cx0qi+gkYB7cYTg/NqSmovYL6hghT6bE02EqeXKo3T37HzY?= =?us-ascii?Q?DPenPkD96gCqQ4JXDs7YG/cz/BWHgyeGMIj/Wrx/xD2Hx2RjHD4uVSKymXPP?= =?us-ascii?Q?LAmj/IHqsEzO6STYdEceJWVKXTZ+aIBShmPip99o/2Cr0jUfXgSAwGRti3zw?= =?us-ascii?Q?heO20bYE0MMpIwrb4XJeNVNw1W6Kxv7rQh36NyWunj4and10F9g/R4cOckkn?= =?us-ascii?Q?WnYb2zf7EmR2pDEwZxKZnGZqfVWIlbBh3LYlndBZLNvJURAGOn60P4HNxpGC?= =?us-ascii?Q?ODKYorjX3Z4qyUsa0JbuWSfOOaS0tATbFh7Gj378lwFdEil700BryTLZyglw?= =?us-ascii?Q?kIbGw6SvQLnjouMWXGveF0ymTlPXHkvNS99tQAu9qfARoXLJ1pnKz+gpCtYK?= =?us-ascii?Q?mVxMksLnmYGI5U12wJezEywldUZRIIwXXEVRHFXCbeGyv9nLdm0T/DF+7UH4?= =?us-ascii?Q?UQm3DppsKt2AsukVZJkAapgPkimGlzzq8LUi2YBA3oqWmgpdM/YUl+fep2Ou?= =?us-ascii?Q?PAO9lidQdd2m2V2Ktx/MUrlDNYoJaDzeHT1Q6eh89G9R2S0ZIImSw8TfWHWE?= =?us-ascii?Q?Mrjj4cTiS1jLLxKOjRIPw5vxmy4zUa+yA+X4+Vi1rs261nKsktaRozjdKCNZ?= =?us-ascii?Q?ybcQG3acKPVvMBwmIyD4IOJYvx+VXwhx7ghRK0tP8Ud0Ompn6i6qulru+Cve?= =?us-ascii?Q?2DPNeLu3QhDdARW2J7+exQr9hzJm6sQf4j+EcqJzUZke0rybYJ4uwqasEbb9?= =?us-ascii?Q?S5GyW6g644kbudGiESxPPKY4twZUcwb8CoA3hfOKC88Ynz2/vHmyiDVAeuIN?= =?us-ascii?Q?09jXLO/ltVjHaaEMB2mDGCYWAETXuDvBYsHye8sUevhEQBcceZjsT746ukKH?= =?us-ascii?Q?6Oe1WSF/rWOG9dbLBGiHkiW2OG109VN3ukuKlDmir6h7zdk8usldBczsFEO+?= =?us-ascii?Q?6XBqZg9mvfsEOVu31mg6PQBPxxTYx0CehBnP/S7j234Mn3Ewanf7wQiviLE1?= =?us-ascii?Q?ekKY5hJ+2w=3D=3D?= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8PR11MB5749.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8975b58c-5acb-460c-5ee0-08da2678e2ef X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Apr 2022 05:03:07.0990 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ujYS3UKwiN/3wXEtLzqE7rJOvD9ygjovxa3Uia3OVrJZafwvg5hXX7PSeV6P+Y0E9f8zq04brOHMXlKk8CyfY7Lm6ztJ+0bGIImElZwtPVA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR11MB4682 X-OriginatorOrg: intel.com Content-Transfer-Encoding: quoted-printable X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: "Metzger, Markus T via Gdb-patches" Reply-To: "Metzger, Markus T" Cc: "gdb-patches@sourceware.org" Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" Hello Zied, >diff --git a/gdb/nat/linux-btrace.c b/gdb/nat/linux-btrace.c >index b0d6dcd7cf1..a9aaa9c88b3 100644 >--- a/gdb/nat/linux-btrace.c >+++ b/gdb/nat/linux-btrace.c >@@ -486,9 +486,10 @@ linux_enable_bts (ptid_t ptid, const struct >btrace_config_bts *conf) > if (fd.get () < 0) > diagnose_perf_event_open_fail (); > >+ long page_size =3D sysconf (_SC_PAGESIZE); Please check the return value. You may just error out but we should detect errors, at least. > struct perf_event_mmap_page *header =3D (struct perf_event_mmap_page *) > data.get (); >- data_offset =3D PAGE_SIZE; >+ data_offset =3D page_size; Hmmm, I would have expected a compiler warning, here, since PAGE_SIZE is now long and DATA_OFFSET is __u64. > /* Allocate the configuration page. */ >- scoped_mmap data (nullptr, PAGE_SIZE, PROT_READ | PROT_WRITE, >MAP_SHARED, >+ long page_size =3D sysconf (_SC_PAGESIZE); Here, we'd also want to check the return value. >@@ -661,7 +663,7 @@ linux_enable_pt (ptid_t ptid, const struct >btrace_config_pt *conf) > size_t length; > __u64 data_size; > >- data_size =3D (__u64) pages * PAGE_SIZE; >+ data_size =3D (__u64) pages * page_size; Hmmm, this also looks like the compiler would want to warn about signed and unsigned multiply. Regards, Markus. Intel Deutschland GmbH Registered Address: Am Campeon 10, 85579 Neubiberg, Germany Tel: +49 89 99 8853-0, www.intel.de Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva = Chairperson of the Supervisory Board: Nicole Lau Registered Office: Munich Commercial Register: Amtsgericht Muenchen HRB 186928