From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id KvaWCWab8mWeZQYAWB0awg (envelope-from ) for ; Thu, 14 Mar 2024 02:38:30 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=NU7/3+NW; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 0FFB21E0BB; Thu, 14 Mar 2024 02:38:30 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 95FE11E030 for ; Thu, 14 Mar 2024 02:38:27 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id D7CB03857BB5 for ; Thu, 14 Mar 2024 06:38:26 +0000 (GMT) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.11]) by sourceware.org (Postfix) with ESMTPS id EE13E3858C31 for ; Thu, 14 Mar 2024 06:38:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org EE13E3858C31 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=intel.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org EE13E3858C31 Authentication-Results: server2.sourceware.org; arc=fail smtp.remote-ip=192.198.163.11 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1710398288; cv=fail; b=KBZj0v4WFmaJ2X/BaHo3NODOT1IQKnOlO+RBDv+8hTt+u1zj0cDM682rWpNNsPsVe5FWsIsBIbJDOvXODuUlVPbhAtcmwBsfjVxiBh9CSWXJAJzXAre/8W/+OBdMs3bm3ma9hhEAWGiGGEaZMhN5IzaCAfC8/iclFXyfdW6s0JE= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1710398288; c=relaxed/simple; bh=eJyG2OMcIBGLVGyqs5L43n9+rWXsNSdytR6vsz0AVZE=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=eoVDHtJXTa1jdagTrSTomXgGrb9O0d7S51rkvomA+L1P8gXbSlRzdl8kl6HPPsu1E2KdpKqiTFPsBy1F3NPXmYTtwlzCDMdFVq8jWf1oSacb69lyFuF5SswH/ohmbeTICWKVlH9okj9yXNZTSZHoCquDVu6Wfg1vUs7W+CMf0SM= ARC-Authentication-Results: i=2; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1710398284; x=1741934284; h=from:to:cc:subject:date:message-id:references: in-reply-to:mime-version:content-transfer-encoding; bh=eJyG2OMcIBGLVGyqs5L43n9+rWXsNSdytR6vsz0AVZE=; b=NU7/3+NWAcRXGCGhotxdh6bhamCiQ6xUn30KBy0gqH44Q5ALi/YBd0Sm Pl1yrP/vXlNCc1+A0JRUbpyVJI/KnNyEShrwIW0Lx6obNCoGuGd8r9018 x0YqOxcbIpAVRVqsfyNzZQmhrx4p4mux88Nd4qkfJudh/bKsnRDW5rTFO qM1DYPG+8eAtJRvsFU+nd6p9uvxXqj9CCuYQ00rc8cYKXfNb2noo4WhfI iva+AttV1TFxMBfNCFwEtUNkstvNg8E4Q580RClDtgto1PnvafofiirB9 akctQwBZFZcs9xjGcOmVnvL7raZHMLcG+fMWtQCEhZqs/UbzENuYLZYKU w==; X-IronPort-AV: E=McAfee;i="6600,9927,11012"; a="15841806" X-IronPort-AV: E=Sophos;i="6.07,124,1708416000"; d="scan'208";a="15841806" Received: from fmviesa005.fm.intel.com ([10.60.135.145]) by fmvoesa105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Mar 2024 23:38:01 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,124,1708416000"; d="scan'208";a="16662400" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmviesa005.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 13 Mar 2024 23:38:01 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Wed, 13 Mar 2024 23:38:01 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Wed, 13 Mar 2024 23:38:01 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.101) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Wed, 13 Mar 2024 23:38:00 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FV47/RhWV/ocFQS1yPDkCQ8eFnYG/wud2Pmhq4bO5QNHnK7zl50QPibhwZCsDSNdpV0BLmu/U2C/jeXn93HRcarJ+MmyvZ4qVYNIyGTF3TTWWRGALV1PLsNKJPPSC4vITOX7UIbY1wBET3ayusy0UvJdZvL9VKGU5+boetVKd+Lk0ZuS8XoVJzXA2FSXqlm9mvYqmaR+vG1ERvl85xZgbi77zDUdK7o9p0YaM3W5+Km/NZBK9VuLKGefEtCscuTIycomXgZbQqfzaAILLgY4U7KGziFr91Nc/D74PQgXWo6J7GbkdZewA73uQAMEbX8mU40IVW6uqDOr6T5TO8mywQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fyLh8oW8Ik3WzjaIyl/zNGIPZuRx7flGSR6QlYjBZ1I=; b=Ax/NHKNvzyh6D1RzmhZ+WZgAoWgk8+G44OEQmakGIr8W0PJOxtfFQjHkQ7dDV4TP9/0Q1y7WjXEJPHdycb+CMzK2MTfNgqyy7Z2bQr6ZVz1nH/IjFYGoyxp2hXhnwvxoLMdpcMsSHp4FchEupfwS/MqKAoQ5604B7PfW0aJBSYszGQljXgA+K7ND8lEDhbo0q9KLgjFpFpit/qAP9vd0G/fZt3cLQ+nTKqB5oHvfpPQASfJOzXoZKf/Y0pad9u4DqFvvfF4u4hSUPrgu5Nn5PgiyAgf0z5/ok6oE1ceGjNUZD9c00RRn9gMnl0sqVsHw4O4WyBvzVSEFtr4Bo1b1qQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM8PR11MB5749.namprd11.prod.outlook.com (2603:10b6:8:10::15) by CYXPR11MB8754.namprd11.prod.outlook.com (2603:10b6:930:dc::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7386.17; Thu, 14 Mar 2024 06:37:58 +0000 Received: from DM8PR11MB5749.namprd11.prod.outlook.com ([fe80::9cd7:dc83:b05b:c77d]) by DM8PR11MB5749.namprd11.prod.outlook.com ([fe80::9cd7:dc83:b05b:c77d%5]) with mapi id 15.20.7386.017; Thu, 14 Mar 2024 06:37:58 +0000 From: "Metzger, Markus T" To: Alex Chronopoulos CC: "Eli Zaretskii (eliz@gnu.org)" , "gdb-patches@sourceware.org" Subject: RE: [PATCH] Change message when reaching end of reverse history. Thread-Topic: [PATCH] Change message when reaching end of reverse history. Thread-Index: AQHadYf2S8lNkW6ihkCD39cydG0JHbE2xkWg Date: Thu, 14 Mar 2024 06:37:57 +0000 Message-ID: References: <20240313204830.2521708-1-achronop@gmail.com> In-Reply-To: <20240313204830.2521708-1-achronop@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM8PR11MB5749:EE_|CYXPR11MB8754:EE_ x-ms-office365-filtering-correlation-id: c880eb07-6f3e-4477-c919-08dc43f14990 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: TatQj6qZKjV63sa2naWfJzm7xgQD52cpawyaiFKACt/2sJ6g9cLQRLxrLEB79Bg737DMYGLSeH9jCU9NFkqJYnWG21oFk6BDxEaes1sFcZ3PEvTHY2nhcwA5rjgS87m+fLfr9pH416Y0SccrQ6bES45Amtm8wlxjHeNdnE4QzF/XoZlwGL6GpCa36TWNYkgqgodhbkcD9CIswg5Xqpi167V74h6qCkEV1AO4/bLdCAIqm03WUkoUN9YlTavGxo4onq2yQi06lcT0B/apYyC6KQpRkdNIeheTnJM2llgHALN5M0YFi+WMs+Ywa6oOrgken1wkSe03QCPAnYTwOorbXDj9LAdyUBvzB6d2b3Uo8tYMwScqjnLEYr4rPe9yIX3UOSLGppypvQ2KgBdkUvj4uRCGeHH2IQ1UCcjnznWRZPGfuNxQrjz+T1xGo/jBCpeTPRFJ6kYZ/BmrWIP3RAa1IJ9v3fZgUr9m5azcrsSQAzsuzY6TdC54DJMazltkJanZBL2nz/EtNNy9tIhgbIhhtdnDgD1xyb8U4n/BlNHf7qn+HSN8qVup6A/lTeUzDHBuXMzxXQobkxl+re9mEVxE4DByWyAUhDamYWvGUzR92vyBzm+ZNk1wWXOTVyHVoD9aX82mOssNmcJmOMznN4hdzJAMfK3R4EeixfgRHF388Cg= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM8PR11MB5749.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(1800799015)(376005)(38070700009); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?QqV5uKFWwGK2Mgcr98deoU4Qcy1UJ0AWphyP7fXLd+qi0pAJp5jhvF3359C1?= =?us-ascii?Q?emS0zVEwA1lKUOrKhW3tmdQh7REkwcb6JKzYC92xcIpiNNeNZW/m4LVf4NQ5?= =?us-ascii?Q?0WMhn6Uo08QjaOOnQdfAcrbJJd68x1hrcFd2t4htW0/SuZiFVW2ZKjWUirXM?= =?us-ascii?Q?wUzFCPGuu+FadLV2OMWwnUCxrGVfM2udkD0CzgAcRDejN+e0TB4ZI4st+ZPi?= =?us-ascii?Q?b9SsePxF0LYmGvunL4IB2Eb6i53NJCfi8Iw1pNk4azjiebP6VfoRDBkipwTg?= =?us-ascii?Q?+UMw0gF22rIVzgITi4k9X/mwQmiuIqc/SLeE/JFui2o867OVuj2dBa0pdfxE?= =?us-ascii?Q?ztx6JPv9eaClC7JKpDP4iwVCLZLYKZb/eOV7eU195hrXoiYQ8Hm2oMgFwSp+?= =?us-ascii?Q?B6rPZMdvlAakbUblVjpcrAkhOXZvVuw2LMh4o00dUhhh/dNER1p1FwZb+yyd?= =?us-ascii?Q?VPfrPEQoQ+/86nscffQuLMskayUWjcdNpCoXZpcfM2C08CpdAFC2oWNZVJkw?= =?us-ascii?Q?oIvv+nnNEx+7R/FiRHBcw/ZaU/R+GicPyH9AIzwsg0dhW9JRkAcscGmuSQkH?= =?us-ascii?Q?0fISu0LEK4WuxZY/8K9czaGWq5umk2DitCtkysKZY3uqLl37Y4pVWPV4v+W6?= =?us-ascii?Q?gPXhMzL4pkk020Gs0+HAcfRS4KQWDbNYQKSjG0t1SLs0M+GrSyEmU4no+KXM?= =?us-ascii?Q?bOXole91Pp4GRB6p7G08UNYtvtoTaXQCb3VoHaLeceRrChnSyqM+q+TUfwq1?= =?us-ascii?Q?pjwY47G5DU3yez1D1bZJDBz5cnpkT0o8buBZTyrrcOntNurZ1MuTvrfSsxAj?= =?us-ascii?Q?D50pqPjmBP9yf3mX60djTGN1R0xnijry2/r55RJClu2bboWNDz5S/EwoJerY?= =?us-ascii?Q?0shPnoUV/YFFTr2nMNR8bucEs6GRl2KAeF4ovu/m5yT0SFMo82KtG0fkuxDu?= =?us-ascii?Q?xjxCKKK4H+wsh/zTo1IyeZqXPIeTwq598rIfb5CU3VbSfCmkP/s+I1Twslek?= =?us-ascii?Q?UaGl9h9tlo2jH+AFSqUvQSzU2xzh3gX2BKTEop3AJDpmRGNOcGetpGOfzNzy?= =?us-ascii?Q?EfuxUdxrV0Xbg0Ubqt6MpC8rxJsSQ5493npeP8QWgB7CfxOGX+IDjoE4zxLm?= =?us-ascii?Q?IKsYtZTBN/JFvZgmKMyF/yWjkPXHYUkg+gNgb2mNQ0/NJYpmQ4Q98xqeyHDw?= =?us-ascii?Q?VrCuHl4CZ47zaAFFzITO7VLcFLomhdLjecgueBTIV+tdqnKVRHZ49UgBeMIM?= =?us-ascii?Q?5ND57e70tPQ6cfjFpsHr1/AMUQkPEcje9xQZnyziUeN73+zn3eduLGS5u+Qm?= =?us-ascii?Q?M3SF8w+mIHt9sG6mvXkAio/+ojF70EH7aSu07sNggknoaTmAm9krAceb2iHf?= =?us-ascii?Q?6AuzHgWRjI5DDvTBmbqEgOYfB5pDgH5jTI36iMWnR54w0a9KDBkU19Kbf+kw?= =?us-ascii?Q?fPfAkzid3xOyZM2D4bOjoR7LTmtJr/Bfyqd+g6FLw9/QFD+aTVF8BJ5yP4Ec?= =?us-ascii?Q?yoxLcMtDVcVl6250b9QdK1Xz8W9XFlb/MUBdJa8Nu/0xDZrMDt8Gh7vaI+S9?= =?us-ascii?Q?L52p2p2SHMFzYtNHz64FmrWw9JIBqn1JslMv7j/6?= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8PR11MB5749.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c880eb07-6f3e-4477-c919-08dc43f14990 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Mar 2024 06:37:57.9936 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: cn7ukFN+zUGqK3I0/dpdo8H4+W2GSaToPu3fry4v4viO6wHtwfB7lpYClKElc1dMy44VTs6zfMlS/Rw+UWbszn6yRKSfmIcRK44y4MiOaFY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CYXPR11MB8754 X-OriginatorOrg: intel.com Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-10.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Hello Alex, I like the idea, but I find the wording a bit verbose. Can we find somethi= ng shorter? E.g. "reached beginning of reverse-execution history" vs "reached end of ~". Not sure if that's clear enough that we're recording again. We could also = omit the "reached end of ~" part and just say "switching to recording mode". > if (uiout->is_mi_like_p ()) > uiout->field_string ("reason", async_reason_lookup >(EXEC_ASYNC_NO_HISTORY)); >+ else if (execution_direction =3D=3D EXEC_FORWARD) >+ uiout->text ("\nNo more reverse-execution history for emulation. " >+ "Going forward will continue executing and recording.\n"); > else >- uiout->text ("\nNo more reverse-execution history.\n"); >+ { >+ gdb_assert (execution_direction =3D=3D EXEC_REVERSE); >+ uiout->text ("\nNo more reverse-execution history.\n"); >+ } We should probably give MI a similar indication, although that would likely break existing MI consumers. Not sure how opt-in is handled in MI. regards, Markus. >-----Original Message----- >From: Alex Chronopoulos >Sent: Wednesday, March 13, 2024 9:49 PM >To: gdb-patches@sourceware.org >Cc: Alex Chronopoulos >Subject: [PATCH] Change message when reaching end of reverse history. > >In a record session, when we move backward, GDB switches from normal >execution to simulation. Moving forward again, the emulation continues >until the end of the reverse history. When the end is reached, the >execution stops, and a warning message is shown. This message has been >modified to indicate that the forward emulation has reached the end, but >the execution can continue as normal, and the recording will also continue. > >Before this patch, the warning message shown in that case was the same as >in the reverse case. This meant that when the end of history was reached in >either backward or forward emulation, the same message was displayed: > >"No more reverse-execution history." > >This message remains for backward emulation. However, in forward >emulation, >it has been modified to: > >"No more reverse-execution history for emulation. Going forward will >continue executing and recording." > >The reason for this change is that the initial message was deceiving, >making the user believe that forward debugging could not continue. > >Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=3D31224 >--- > gdb/NEWS | 5 ++++ > gdb/infrun.c | 8 ++++- > gdb/testsuite/gdb.btrace/non-stop.exp | 30 ++++++++++++------- > gdb/testsuite/gdb.reverse/break-precsave.exp | 4 +-- > gdb/testsuite/gdb.reverse/break-reverse.exp | 2 +- > .../gdb.reverse/machinestate-precsave.exp | 2 +- > 6 files changed, 36 insertions(+), 15 deletions(-) > >diff --git a/gdb/NEWS b/gdb/NEWS >index 2638b3e0d9c..f2e85776a53 100644 >--- a/gdb/NEWS >+++ b/gdb/NEWS >@@ -13,6 +13,11 @@ > the background, resulting in faster startup. This can be controlled > using "maint set dwarf synchronous". > >+* In a record session, when a forward emulation reaches the end of the >reverse >+ history, the warning message has been changed to indicate that the end = of >the >+ history has been reached. It also specifies that the forward execution= can >+ continue, and the recording will also continue. >+ > * Changed commands > > disassemble >diff --git a/gdb/infrun.c b/gdb/infrun.c >index bbb98f6dcdb..e129eb0582f 100644 >--- a/gdb/infrun.c >+++ b/gdb/infrun.c >@@ -9244,8 +9244,14 @@ print_no_history_reason (struct ui_out *uiout) > { > if (uiout->is_mi_like_p ()) > uiout->field_string ("reason", async_reason_lookup >(EXEC_ASYNC_NO_HISTORY)); >+ else if (execution_direction =3D=3D EXEC_FORWARD) >+ uiout->text ("\nNo more reverse-execution history for emulation. " >+ "Going forward will continue executing and recording.\n"); > else >- uiout->text ("\nNo more reverse-execution history.\n"); >+ { >+ gdb_assert (execution_direction =3D=3D EXEC_REVERSE); >+ uiout->text ("\nNo more reverse-execution history.\n"); >+ } > } > > /* Print current location without a level number, if we have changed >diff --git a/gdb/testsuite/gdb.btrace/non-stop.exp >b/gdb/testsuite/gdb.btrace/non-stop.exp >index 62c940e4cd6..7ce3008c120 100644 >--- a/gdb/testsuite/gdb.btrace/non-stop.exp >+++ b/gdb/testsuite/gdb.btrace/non-stop.exp >@@ -79,7 +79,7 @@ proc gdb_cont_to_bp_line { line threads nthreads } { > $nthreads > } > >-proc gdb_cont_to_no_history { threads cmd nthreads } { >+proc gdb_cont_to_no_history_backward { threads cmd nthreads } { > gdb_cont_to $threads $cmd \ > [multi_line \ > "No more reverse-execution history\." \ >@@ -89,6 +89,16 @@ proc gdb_cont_to_no_history { threads cmd nthreads } >{ > $nthreads > } > >+proc gdb_cont_to_no_history_forward { threads cmd nthreads } { >+ gdb_cont_to $threads $cmd \ >+ [multi_line \ >+ "No more reverse-execution history for emulation\. Going for= ward >will continue executing and recording\." \ >+ "\[^\\\r\\\n\]*" \ >+ "\[^\\\r\\\n\]*" \ >+ ] \ >+ $nthreads >+} >+ > # trace the code between the two breakpoints > with_test_prefix "prepare" { > gdb_cont_to_bp_line "$srcfile:$bp_1" all 2 >@@ -176,14 +186,14 @@ with_test_prefix "reverse-step" { > with_test_prefix "continue" { > with_test_prefix "thread 1" { > with_test_prefix "continue" { >- gdb_cont_to_no_history 1 "continue" 1 >+ gdb_cont_to_no_history_forward 1 "continue" 1 > gdb_test "thread apply 1 info record" \ > ".*Recorded \[0-9\]+ instructions \[^\\\r\\\n\]*" > gdb_test "thread apply 2 info record" \ > ".*Replay in progress\. At instruction 5\." > } > with_test_prefix "reverse-continue" { >- gdb_cont_to_no_history 1 "reverse-continue" 1 >+ gdb_cont_to_no_history_backward 1 "reverse-continue" 1 > gdb_test "thread apply 1 info record" \ > ".*Replay in progress\. At instruction 1\." > gdb_test "thread apply 2 info record" \ >@@ -193,14 +203,14 @@ with_test_prefix "continue" { > > with_test_prefix "thread 2" { > with_test_prefix "continue" { >- gdb_cont_to_no_history 2 "continue" 1 >+ gdb_cont_to_no_history_forward 2 "continue" 1 > gdb_test "thread apply 1 info record" \ > ".*Replay in progress\. At instruction 1\." > gdb_test "thread apply 2 info record" \ > ".*Recorded \[0-9\]+ instructions \[^\\\r\\\n\]*" > } > with_test_prefix "reverse-continue" { >- gdb_cont_to_no_history 2 "reverse-continue" 1 >+ gdb_cont_to_no_history_backward 2 "reverse-continue" 1 > gdb_test "thread apply 1 info record" \ > ".*Replay in progress\. At instruction 1\." > gdb_test "thread apply 2 info record" \ >@@ -215,8 +225,8 @@ with_test_prefix "no progress" { > gdb_test "thread apply 1 record goto end" ".*" > gdb_test "thread apply 2 record goto begin" ".*" > >- gdb_cont_to_no_history 1 "continue" 1 >- gdb_cont_to_no_history 1 "step" 1 >+ gdb_cont_to_no_history_forward 1 "continue" 1 >+ gdb_cont_to_no_history_forward 1 "step" 1 > gdb_test "thread apply 1 info record" \ > ".*Recorded \[0-9\]+ instructions \[^\\\r\\\n\]*" > gdb_test "thread apply 2 info record" \ >@@ -227,8 +237,8 @@ with_test_prefix "no progress" { > gdb_test "thread apply 1 record goto begin" ".*" > gdb_test "thread apply 2 record goto end" ".*" > >- gdb_cont_to_no_history 2 "continue" 1 >- gdb_cont_to_no_history 2 "step" 1 >+ gdb_cont_to_no_history_forward 2 "continue" 1 >+ gdb_cont_to_no_history_forward 2 "step" 1 > gdb_test "thread apply 1 info record" \ > ".*Replay in progress\. At instruction 1\." > gdb_test "thread apply 2 info record" \ >@@ -238,7 +248,7 @@ with_test_prefix "no progress" { > with_test_prefix "all" { > gdb_test "thread apply all record goto begin" ".*" > >- gdb_cont_to_no_history all "continue" 2 >+ gdb_cont_to_no_history_forward all "continue" 2 > gdb_test "thread apply 1 info record" \ > ".*Recorded \[0-9\]+ instructions \[^\\\r\\\n\]*" > gdb_test "thread apply 2 info record" \ >diff --git a/gdb/testsuite/gdb.reverse/break-precsave.exp >b/gdb/testsuite/gdb.reverse/break-precsave.exp >index b9d94681247..6d3b95933d4 100644 >--- a/gdb/testsuite/gdb.reverse/break-precsave.exp >+++ b/gdb/testsuite/gdb.reverse/break-precsave.exp >@@ -73,7 +73,7 @@ proc precsave_tests {} { > -re ".*Breakpoint $decimal,.*$srcfile:$end_location.*$gdb_prompt $" >{ > pass "go to end of main forward" > } >- -re "No more reverse-execution history.* end of main .*$gdb_prompt >$" { >+ -re "No more reverse-execution history for emulation. Going forward >will continue executing and recording.* end of main .*$gdb_prompt $" { > pass "go to end of main forward" > } > } >@@ -103,7 +103,7 @@ proc precsave_tests {} { > -re ".*Breakpoint $decimal,.*$srcfile:$end_location.*$gdb_prompt $" >{ > pass "end of record log" > } >- -re "No more reverse-execution history.* end of main .*$gdb_prompt >$" { >+ -re "No more reverse-execution history for emulation. Going forward >will continue executing and recording.* end of main .*$gdb_prompt $" { > pass "end of record log" > } > } >diff --git a/gdb/testsuite/gdb.reverse/break-reverse.exp >b/gdb/testsuite/gdb.reverse/break-reverse.exp >index 1dd327ca654..bf74d6f7d07 100644 >--- a/gdb/testsuite/gdb.reverse/break-reverse.exp >+++ b/gdb/testsuite/gdb.reverse/break-reverse.exp >@@ -80,7 +80,7 @@ gdb_test_multiple "continue" "end of record log" { > -re ".*Breakpoint $decimal,.*$srcfile:$end_location.*$gdb_prompt $" { > pass "end of record log" > } >- -re "No more reverse-execution history.* end of main .*$gdb_prompt $"= { >+ -re "No more reverse-execution history for emulation. Going forward w= ill >continue executing and recording.* end of main .*$gdb_prompt $" { > pass "end of record log" > } > } >diff --git a/gdb/testsuite/gdb.reverse/machinestate-precsave.exp >b/gdb/testsuite/gdb.reverse/machinestate-precsave.exp >index 19c5934bfdf..693c304bc18 100644 >--- a/gdb/testsuite/gdb.reverse/machinestate-precsave.exp >+++ b/gdb/testsuite/gdb.reverse/machinestate-precsave.exp >@@ -85,7 +85,7 @@ gdb_test_multiple "continue" "go to end of main >forward" { > -re ".*Breakpoint $decimal,.*$srcfile:$endmain.*$gdb_prompt $" { > pass "go to end of main forward" > } >- -re "No more reverse-execution history.* end main .*$gdb_prompt $" { >+ -re "No more reverse-execution history for emulation. Going forward w= ill >continue executing and recording.* end main .*$gdb_prompt $" { > pass "go to end of main forward" > } > } >-- >2.42.0 Intel Deutschland GmbH Registered Address: Am Campeon 10, 85579 Neubiberg, Germany Tel: +49 89 99 8853-0, www.intel.de Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva = Chairperson of the Supervisory Board: Nicole Lau Registered Office: Munich Commercial Register: Amtsgericht Muenchen HRB 186928