From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id bGppJgg3E2KWDgAAWB0awg (envelope-from ) for ; Mon, 21 Feb 2022 01:54:00 -0500 Received: by simark.ca (Postfix, from userid 112) id 8C92B1F3C9; Mon, 21 Feb 2022 01:54:00 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id AC0011EA69 for ; Mon, 21 Feb 2022 01:53:59 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id AA9FC386EC1D for ; Mon, 21 Feb 2022 06:53:58 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org AA9FC386EC1D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1645426438; bh=ojPzOkoNWI5QnG+NOyv1OhIHhli0b/uVqDLny1t20vM=; h=To:Subject:Date:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=F2MvSi3ptIYSjJgTWKHHqu/pOt9Tw0y8mapaMgfp+VujFiJUcazLrksvJbzZGLxCK jHvuE4dfiv2Mv4YEIHgmRNgK4opAPzB1MWpX64Prmyi418QZdg0r1JwIPzzgsLuoZv RBVgZK0X/oAWJyr3cZSnD1HiY9ecGeuUZfdLaG4Y= Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by sourceware.org (Postfix) with ESMTPS id 0D26D3858406 for ; Mon, 21 Feb 2022 06:53:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 0D26D3858406 X-IronPort-AV: E=McAfee;i="6200,9189,10264"; a="312191186" X-IronPort-AV: E=Sophos;i="5.88,385,1635231600"; d="scan'208";a="312191186" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Feb 2022 22:53:35 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,385,1635231600"; d="scan'208";a="504891709" Received: from orsmsx604.amr.corp.intel.com ([10.22.229.17]) by orsmga002.jf.intel.com with ESMTP; 20 Feb 2022 22:53:35 -0800 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Sun, 20 Feb 2022 22:53:35 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Sun, 20 Feb 2022 22:53:35 -0800 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.169) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Sun, 20 Feb 2022 22:53:34 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Pe7xFA+aWKWLsOq02NMFu2q3EN9uYy7VjtHRwEVsJEFBxaWp4aKxQAncrM+G/ssaTZXS9r1RyCpH8L5PEvIugCllKoXRqGmzuE6R9fmJK1+88ARXk0+neFh6fxk7Hl+dN9f4RIoCPfm7CvMaLPGd9QD64WLQshTticueVWaUY6cL75rzTnpqAqqVVyBJQdBZB5bxUvgFqL7gIt9isJkS3Cu/AlYBrFZ6zDSR3llRINNEGR0BMdGTQBYwTPVPqj9IrGVrsZ/1D4L40XiIgtzLgby+1xYEeto/Uhq/jD8z37GQ/Ev6ZBYkDjgGdlanIzmH7EFvzp0ZlNexjJxt3NYzvQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KtQtg7m9/dVilWLUfJmUixOvqmUPhSg3EkmuNRlLzM4=; b=BedKgAwDR5q29rzYGjN8GIRZC9RLcERAZVR9sCnx/L2lxg3/g5inDoHuj3LXHwQ/DOLIeaeWdeQTBPjaUZn8MRRemm0IqFEJErumLNmkX9hEMhVwVHqSlmRHjd5u0PHK+touVQfzgePgShlSF3vJONFvYIzw7X8V1ULSKgRB/bMFsf5zcOojbxMrBa2dge7EfdjCO3hPQQBFfeHftki9xpnNNter4Uen4f/tNjXL9GIM+SI1cekQ5j+Dki5AAtk9Qg8+rGgmD8Rr7SOQBbMisQgsk9O6OUAw0m9PaqTz5sDjf6UMf/qoEmrbvSVhfO9V723d6CFY9COExSE6lYtRpQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM8PR11MB5749.namprd11.prod.outlook.com (2603:10b6:8:10::15) by CY4PR11MB1431.namprd11.prod.outlook.com (2603:10b6:910:3::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.24; Mon, 21 Feb 2022 06:53:33 +0000 Received: from DM8PR11MB5749.namprd11.prod.outlook.com ([fe80::8072:5ca1:297a:f7f9]) by DM8PR11MB5749.namprd11.prod.outlook.com ([fe80::8072:5ca1:297a:f7f9%5]) with mapi id 15.20.4995.027; Mon, 21 Feb 2022 06:53:33 +0000 To: Kevin Buettner Subject: RE: [PATCH v3] Support glibc multiple namespace extension Thread-Topic: [PATCH v3] Support glibc multiple namespace extension Thread-Index: AQHXt841fh++1mKyOUOwLwh6jA+2FKyONpeAgACJUSCAD61xIA== Date: Mon, 21 Feb 2022 06:53:33 +0000 Message-ID: References: <20220210160823.35a8508e@f35-zws-1> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.200.16 dlp-product: dlpe-windows x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 3c2ee9c7-c296-4d06-3d4c-08d9f506e068 x-ms-traffictypediagnostic: CY4PR11MB1431:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: uP9SNUMnd6EEag4PmbJFylYsGhkq7UiBytTsI7+0NHx7cT0+D539ym8ShemhFLLmGRsSojGmXFaiO++V3u5g2baJmJLbvSSDgfDKuET8fTnCEtILHhcpYgJHaFbRrAf1SrBY9XZvTD7roQ6CLKoIkwJ8oEkoE31nJyItaERdzFVz5Q37Za8HPPzaED5zXnB764hdFNOThuFndPc0bPHQFdqGnmBpKzAWc/vaMP2JM5RC1t0AqmMdpXNbSZAtwhH70q+Ggva04mbIF3OQfnxz1Chuf9l+NqVORR0ovObcovEsuprfTxG2L02WfRfN0uItDCNIIi4bhgdSUguSoS+5QEw+l0M0FU8WrrBJCgtEiaEoGF5rYWR6ROOk3SWEjMFXe6voaQ0LwcybrrA+5PEyr/1m1FdFnkzjNy4iCzgfdkOEG1v4m+WicuidY+dQwGP9+OPvfHjHQQutXzRgeUO4XFTc0CXLLMwyHkY0shh5dIN1ZXH4VoaPUiwPIqkT44eSGgv6EXl1F82xxFhaDFd13bNeQv3u+wm2aN/VYrT8MBcxtP6BvOu1oA9ri1ZabLSqMRQ1l6NHFQNRqfm0PZ7Nmrdtf6BUvTzemiQMWoSgHhjbl/jxeOGzyBzHczDdBO/s3hPOV5kEqQbqXN0k/WQKj+cxqRDqx0jUjeqMetnWwW25V/TWF1N2KIZJzVy1Q7+IlyMirTlgDRQmAseyZ5cMzw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM8PR11MB5749.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(33656002)(83380400001)(76116006)(54906003)(6916009)(38070700005)(316002)(55016003)(52536014)(66946007)(2906002)(82960400001)(66556008)(4326008)(66476007)(66446008)(6506007)(9686003)(7696005)(508600001)(38100700002)(5660300002)(8936002)(64756008)(122000001)(186003)(86362001)(26005)(71200400001)(8676002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?sn48ckDpAtZTVtrhhC58+/MGt8mLmTTfx0kEw5czfU9xj8OxeZQRiV5KJ8nj?= =?us-ascii?Q?2gUSUh8DvooaLo9fcIwNWR8OOyuuDc+zf8ZehIZvyKk6oCdY01gKvhfI9tG9?= =?us-ascii?Q?pLtyeRbn0Vq2MzV/5NmDhuePkxEXJdIeXZQctFGwypwH7fHdnUFdvf1WRrHv?= =?us-ascii?Q?vSM8eJODnJNEaXCe++JDU6cOQCXOvvq9AtrF59Pu9Krd24KHFV7Wh4pTWnwG?= =?us-ascii?Q?Y3LMai5E3GuvchHUh77gDaOQ74a3jC48UKVLY83uUyxlUwJ0vhmA8nujVKCv?= =?us-ascii?Q?ibH1IDyOwl0pRatJGkZ+eUb7LAEewc5xTV6uNYfYiWC4YAotclXAla+hHczM?= =?us-ascii?Q?yCkks8H0Qr6DOtUKOLSQ1n0xlrf//Q8024ezV5zpEK7LHHYOdcZQSDHJ+sJ4?= =?us-ascii?Q?OUSwK+QZ/mMd+xV+gNJ/9JkF/czu6qEctO1J/auMScRKGwERODHxYjtlU7yN?= =?us-ascii?Q?aEHFbHCyvSRUrNz0Hf2xYGnJifE3P7Wqn8GELX5Bk2sVkUr3LrPscPMpcjVn?= =?us-ascii?Q?OZE/WOTp0J8iMw0GfJah5BXITlUni3O7M1x0LC4KJ4gsZ91vq0nKl9SptCOE?= =?us-ascii?Q?nIQFH6of8yUY+59gZ1cVggOhSPolr3KGUjGY7XFQncQ9vYrm0iitl0fxBee4?= =?us-ascii?Q?mb+hpD+6BVYuQeaAUTSiTArSU2bivU95Eb6deN0NT55ZLKAbMVaQseO7rEfj?= =?us-ascii?Q?kW3/4ThmXUeY6BUy+SC6rVlopM3yrvgE3Q+d80xrIBDAp/fbu4PBKrHRqTR7?= =?us-ascii?Q?tR6CfNBaJ+ucdN3TVnowBfDbn1wKD0v/B6zBJyAXOumOLvSFp0ZjDXP8awpj?= =?us-ascii?Q?LCFkoaTjnRR+vDWKitc53E4OoAYfxgwu7AjaeToOEX3y6IhVCMNkYflMGYe6?= =?us-ascii?Q?1xWB3gxxFTgfVJG3xj87jwHU6s/9eNzOD4/PqbeZn9ucuGiEScyMmE7+k6+o?= =?us-ascii?Q?xMoEWj6MyeXix8HV1HoxB9KGvN08TrwbLEJsh08mNPuaemOlfNDc0AFRZ0J5?= =?us-ascii?Q?GFgEUV/2w1Jw+qTwehYqqhi46DyRkAV4Cf8+K7NAZPAeagdyecqiriY2hsed?= =?us-ascii?Q?XvUlxJIbzj5Ll985IfrY5bc+wsQ5DPyiz2Hjn6ir6MlmnZkppnd4cP9Xvvrm?= =?us-ascii?Q?VeabSKuo5IxiGf+ZJQazC3Lp0GnaytXJouwYnN8A5KBa4olg3Df/64sq/jR5?= =?us-ascii?Q?PoNw567fZbebJGluYhZnNXeB9Q5rp7EwNOJjoO3GUyoK/h0nX94IMGn08vOB?= =?us-ascii?Q?t1aMXQS81XhNRIBdrAztsMbExafO68En95SREnmZASL2t5Wiff230HOXH+3Y?= =?us-ascii?Q?YTTikl9UVvwpfTtLdiT4FKPpSrowSrQru/XJQYWkNkeQ5ivmwgzytfBbOBJZ?= =?us-ascii?Q?ah7ksuKmq0fdOnzmrO9TxSL/Jn8M3/C/Gtj5rpsA71vmtCXHn1wPo+jIxRsJ?= =?us-ascii?Q?jl6G7LXoQ9B7D0uHz2P9J51pIgDuo2XFVUcAtRb8259L1GR/wtJbhMFZ9QUG?= =?us-ascii?Q?3xyhABvZdNyxERY0Nyj8tCPOroThzeupQfeM2UeuXrEAnE8h7L7bBd8w1243?= =?us-ascii?Q?AchP2yt1C1okL9QQ/5Yky4F7ryjI6NVTpcWWCuO395meF8s706TLt2Rn8qtd?= =?us-ascii?Q?qSH5IXUFJEKeCiTf/Z9+7Uw016mxMFaoNxbwLTRBSPTK8D2bBp4HObKvNxXy?= =?us-ascii?Q?dm5yOg=3D=3D?= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM8PR11MB5749.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3c2ee9c7-c296-4d06-3d4c-08d9f506e068 X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Feb 2022 06:53:33.1926 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: +oLhUn5RwYlrg3wcrA5L2XjeXf1RBZC2e93AgivIWEHTCzEW+czLNtLGp4htqH/cGaCMTsj3VplO4/CR7iYiQ7QENTxDtSKjA/vIHt+ORgs= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR11MB1431 X-OriginatorOrg: intel.com Content-Transfer-Encoding: quoted-printable X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: "Metzger, Markus T via Gdb-patches" Reply-To: "Metzger, Markus T" Cc: "gdb-patches@sourceware.org" Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" Hello Kevin, >They're not, but this code ... > > /* Walk to the end of the list. */ > for (tail =3D info->solib_list; tail->next !=3D NULL; tail =3D tail->nex= t) > /* Nothing. */; > > /* Don't check shared libraries in other namespaces when updating > shared libraries in a new namespace. */ > if (debug_base =3D=3D info->debug_base) > { > lm_info_svr4 *li =3D (lm_info_svr4 *) tail->lm_info; > prev_lm =3D li->lm_addr; > } > else > prev_lm =3D 0; > >... looks a bit odd to me. We're adding to the same solib_list, yet we use >different prev_lm. Let me look into this some more. This is indeed wrong and leads to if (li->l_prev !=3D prev_lm) { warning (_("Corrupted shared library list: %s !=3D %s"), paddress (target_gdbarch (), prev_lm), paddress (target_gdbarch (), li->l_prev)); return 0; } in svr4_read_so_list(). Assigning prev_lm to zero avoided the warning for the first library in another namespace. I added more test cases to detect this reliably. I'll try organizing SVr4 DSOs in per-namespace lists. Regards, Markus. Intel Deutschland GmbH Registered Address: Am Campeon 10, 85579 Neubiberg, Germany Tel: +49 89 99 8853-0, www.intel.de Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva = Chairperson of the Supervisory Board: Nicole Lau Registered Office: Munich Commercial Register: Amtsgericht Muenchen HRB 186928