Re: [PATCH v5 4/4] gdb, infrun: fix multi-threaded reverse stepping

Guinevere Larsen
2024-04-15T12:44:38Z

On 4/15/24 06:03, Metzger, Markus T wrote:
>>> @@ -179,6 +186,9 @@ struct thread_control_state
>>>
>>> /* Whether the thread was replaying when the command was issued. */
>>> bool is_replaying = false;
>>> +
>>> + /* The execution direction when the command was issued. */
>>> + enum exec_direction_kind execution_direction = EXEC_FORWARD;
>> I'm a bit unsure of this... Mostly wondering if this makes sense to be a
>> thread-specific information. Does it make sense for one thread to have a
>> direction being forward and another backwards? I would think this is not
>> a good idea (if not impossible).
> You can have one thread going forward and the other going backward.
> Both are replaying; we do not allow recording one thread while another
> thread in the same inferior is replaying.

Oh you can? I didn't know btrace was this fancy!

The whole series seems fine to me, then. Reviewed-By: Guinevere Larsen
<blarsen@redhat.com>

--
Cheers,
Guinevere Larsen
She/Her/Hers

>
> Regards,
> Markus.
> Intel Deutschland GmbH
> Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
> Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
> Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva
> Chairperson of the Supervisory Board: Nicole Lau
> Registered Office: Munich
> Commercial Register: Amtsgericht Muenchen HRB 186928