RE: [PATCH v5 00/15] basic linker namespace support

Metzger, Markus T via Gdb-patches
2022-07-18T05:33:30Z

Thanks, Kevin,

>> Not reviewed:
>> > gdb, testsuite: extend gdb_test_multiple checks
>
>I asked a question about this one. Basically, I'd like to understand
>the circumstances which led you to making these changes.

Sorry, I missed your email. I ran into

Invalid cast.
warning: Probes-based dynamic linker interface failed.
Reverting to original interface.

and

warning: Corrupted shared library list

during development.
See https://sourceware.org/pipermail/gdb-patches/2022-February/186135.html.

The other I believe I added for completeness but I see that this warning has been
removed, meanwhile. Let me drop it from my patch.

>
>> > gdb, python: use gdbarch_iterate_over_objfiles_in_search_order
>
>I okayed this one.
>
>> > gdb, ada: collect standard exceptions in all objfiles
>
>That one looked reasonable to me, but an Ada expert may want to
>take a look.
>
>> > gdb, cp: update add_symbol_overload_list_qualified
>
>I said, "LGTM", which is basically an "okay".
>
>> > gdb: update gnu ifunc resolve
>
>I okayed this one.

Sorry, I must have missed your replies on those. I haven't checked the
archive and relied on my email inbox.

>I'd like to see this work go in. So long as it doesn't break existing
>(non-linker namespace) use cases, I'm okay with fixing the other
>problems later on.

As far as I could test (x86-64 on Fedora 35) it does not break anything.
I'll ask Joel about the Ada patches.

regards,
markus.